gstreamer-0.10 moduleset build on osx fails on priv_gst_parse_yylex

[Antoine Martin]

Just had a problem rebuilding gstreamer-0.10 with the moduleset (as per #533):

jhbuild build -f gstreamer
(...)
Making all in parse
  GEN    lex.priv_gst_parse_yy.c
  CC     libgstparse_la-lex.priv_gst_parse_yy.lo
lex.priv_gst_parse_yy.c:1008: warning: redundant redeclaration of 'priv_gst_parse_yyget_column'
lex.priv_gst_parse_yy.c:4: warning: previous declaration of 'priv_gst_parse_yyget_column' was here
lex.priv_gst_parse_yy.c:1010: warning: redundant redeclaration of 'priv_gst_parse_yyset_column'
lex.priv_gst_parse_yy.c:5: warning: previous declaration of 'priv_gst_parse_yyset_column' was here
  CC     libgstparse_la-grammar.tab.lo
grammar.tab.c: In function 'priv_gst_parse_yyparse':
grammar.tab.c:1819: error: too few arguments to function 'priv_gst_parse_yylex'
make[4]: *** [libgstparse_la-grammar.tab.lo] Error 1
make[3]: *** [all-recursive] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
*** Error during phase build of gstreamer: ########## Error running make ERROR_CFLAGS=  -j 2 *** [1/3]

Found this bug: ​parse: fix build with Bison 3.
Applying this patch fixes the build: ​https://bugzilla.gnome.org/attachment.cgi?id=252504&action=diff.

@smo: can you reproduce? can you add the patch to the moduleset?

[Smo]

I can't seem to reproduce this on my older build machine osx 10.5 but I will try on a newer one and see as well.

As long as the patch doesn't cause any issue I don't see why I can't add it.

[Antoine Martin]

Hmmm, this disables mmx acceleration... not that we should be using mp3 at this point, and osx is used as client where CPU usage is negligible anyway.

[Smo]

Tried this on new build machine 32 bit and no issue either. What machine are you doing this on?

*** success *** [1/1]
[user@mac-mini ~]$ sw_vers 
ProductName:    Mac OS X
ProductVersion: 10.11.1
BuildVersion:   15B42

[Antoine Martin]

Not seen this since, must have been a fluke.

[migration script]

this ticket has been moved to: ​https://github.com/Xpra-org/xpra/issues/1063