As can be seen here: http://gstreamer.freedesktop.org/src/gstreamer/, the 1.4.x branch has been abandoned over a year ago. We should switch to the currently supported stable branch.
Please include details of what breaks with this change so we can try to fix it. Sticking with the 1.4 branch is causing problems (see r12249), and even the 1.6 branch is no longer supported as 1.8 is out: https://gstreamer.freedesktop.org/releases/gstreamer/1.8.0.html.
Couldn't wait any longer for 0.17, so done in r12390.
I hit this trivial bug in
(...) In file included from gstosxcoreaudio.c:35: gstosxcoreaudiohal.c: In function '_audio_system_get_default_device': gstosxcoreaudiohal.c:62: warning: ISO C90 forbids mixed declarations and code gstosxcoreaudiohal.c: In function '_audio_device_is_alive': gstosxcoreaudiohal.c:126: warning: ISO C90 forbids mixed declarations and code gstosxcoreaudiohal.c: In function '_audio_device_get_name': gstosxcoreaudiohal.c:272: warning: ISO C90 forbids mixed declarations and code gstosxcoreaudio.c: In function 'gst_core_audio_asbd_to_caps': gstosxcoreaudio.c:419: error: 'kLinearPCMFormatFlagsSampleFractionMask' undeclared (first use in this function) gstosxcoreaudio.c:419: error: (Each undeclared identifier is reported only once gstosxcoreaudio.c:419: error: for each function it appears in.) make: *** [libgstosxaudio_la-gstosxcoreaudio.lo] Error 1
Fixed by patching the source file with:
#ifndef kLinearPCMFormatFlagsSampleFractionShift #define kLinearPCMFormatFlagsSampleFractionShift 7 #endif #ifndef kLinearPCMFormatFlagsSampleFractionMask #define kLinearPCMFormatFlagsSampleFractionMask (0x3F << kLinearPCMFormatFlagsSampleFractionShift) #endif
@smo: Is this the error you encountered? Please always record them. If so, please just merge this as a patch to the moduleset and re-assign to afarr for sound testing. I don't expect major regressions by switching from gstreamer 1.4.x to 1.6.x, but who knows. (briefly tested with opus and mp3)
We should switch to 1.8 for 0.18: see #1168.
I had the same error and created a patch r12528
forced a recompile by removing the source directory and doing
jhbuild buildone --force gst-plugins-good-1.0
Built successfully now needs to be tested.
Sound is good quality, av-sync seems to be within .1 s (at the very outside... looks perfect to my ears).
Disconnecting/reconnecting; pausing/unpausing sound sources; using the application menu to turn speakers off/on; no problems to be found.
Sounds fixed to me. I'll take the liberty of closing.
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/1069