#1074 closed task (fixed)
switch to opus as preferred audio codec
| Reported by: | Antoine Martin | Owned by: | Antoine Martin |
|---|---|---|---|
| Priority: | blocker | Milestone: | 0.17 |
| Component: | sound | Version: | trunk |
| Keywords: | opus | Cc: |
Description (last modified by )
Now that all platforms use gstreamer 1.x, there is no reason not to use opus if both ends support it.
I have used it before and the code tunes it for low latency.
In theory, it will help us with av-sync (#835) because of its much lower latency:
And provides the best (TBC?) quality for any bitrate:
Tasks:
- smo: add opus and its gstreamer plugin to the osx moduleset
- afarr: testing: latency for av-sync, buffer levels, cpu usage, bandwidth usage
- antoine: change the default, assuming all is well, maybe also #1075
Attachments (2)
Change History (13)
Changed 5 years ago by
| Attachment: | 674px-Opus_bitrate+latency_comparison.png added |
|---|
Changed 5 years ago by
| Attachment: | Opus_quality_comparison_colorblind_compatible.png added |
|---|
quality comparison from wikipedia
comment:1 Changed 5 years ago by
| Description: | modified (diff) |
|---|
comment:2 Changed 5 years ago by
Added opus in r11597 builds on my old build machine and the new one.
Rebuilding gst-plugins-bad-1.0 should now include this but I will also make it a dependency so it gets rebuilt.
comment:3 Changed 5 years ago by
| Owner: | changed from Smo to alas |
|---|
(@smo: I assume this is done, re-assigning to afarr)
afarr: testing: latency for av-sync, buffer levels, cpu usage, bandwidth usage
comment:4 Changed 5 years ago by
| Owner: | changed from alas to Smo |
|---|
I believe that the packaging bits are in place as of r11761.
@smo: please ensure the modulesets have an opus dependency somewhere before handing over to afarr.
comment:6 Changed 5 years ago by
| Priority: | critical → blocker |
|---|
comment:7 Changed 5 years ago by
| Owner: | changed from Smo to Antoine Martin |
|---|
Testing right quick with a 0.17.0 r12401 osx client against a 0.17.0 r12453 fedora 23 server, both seem to indicate opus+gdp first on speaker and microphone codec lists (making them the defaults, if I don't miss my guess)... and sound works well.
I don't see anything in the session-info to make it any easier than before to determine which codec is actually in use, other than assuming that the first listed is the one in use.
Unless I'm missing a detail, I think this is ready to be closed.
comment:8 Changed 5 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
I don't see anything in the session-info to make it any easier than before to determine which codec is actually in use
You can see which codec is used in the command output or via "xpra info".
I'll try to stick on session info somewhere.
comment:9 Changed 5 years ago by
I must be the first one to test opus with Ubuntu Xenial, immediately found a bug, fixed in r12468.
comment:11 Changed 5 weeks ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/1074
copyleft 2010 - 2021
bitrate comparison image from wikipedia