xpra icon
Bug tracker and wiki

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#1078 closed defect (fixed)

AttributeError in XpraServer: missing control_command_unlock_batck_delay

Reported by: J. Max Mena Owned by: Antoine Martin
Priority: critical Milestone: 0.17
Component: server Version: trunk
Keywords: Cc:

Description

As per the title:

The latest trunk revision is broken. Attempting to start a server causes the following traceback and error:

xpra main error:
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/xpra/scripts/main.py", line 124, in m
ain
    return run_mode(script_file, err, options, args, mode, defaults)
  File "/usr/lib64/python2.7/site-packages/xpra/scripts/main.py", line 934, in r
un_mode
    return run_server(error_cb, options, mode, script_file, args)
  File "/usr/lib64/python2.7/site-packages/xpra/scripts/server.py", line 1002, i
n run_server
    app = XpraServer(clobber)
  File "/usr/lib64/python2.7/site-packages/xpra/x11/server.py", line 189, in __i
nit__
    X11ServerBase.__init__(self, clobber)
  File "/usr/lib64/python2.7/site-packages/xpra/x11/x11_server_base.py", line 74, in __init__
    GTKServerBase.__init__(self)
  File "/usr/lib64/python2.7/site-packages/xpra/server/gtk_server_base.py", line 41, in __init__
    ServerBase.__init__(self)
  File "/usr/lib64/python2.7/site-packages/xpra/server/server_base.py", line 86, in __init__
    ServerCore.__init__(self)
  File "/usr/lib64/python2.7/site-packages/xpra/server/server_core.py", line 162, in __init__
    self.init_control_commands()
  File "/usr/lib64/python2.7/site-packages/xpra/server/server_base.py", line 662, in init_control_commands
    cmd.do_run = getattr(self, "control_command_%s" % cmd.name.replace("-", "_"))
AttributeError: 'XpraServer' object has no attribute 'control_command_unlock_batck_delay'

Running grep "batck" * -r -i in the source produces about 15 or so matches. After manually editing them(as in every single reference to "batck") to say "batch", everything builds and runs successfully. It's unclear to me if "batck" was a typo or not. Either way, there is some inconsistency somewhere that breaks the latest trunk revision.

Spelunking through the timeline shows that r11606 was the revision that introduced the break. Builds before this revision work fine.


NOTE:

Clients are unaffected. This is confined to servers.

Change History (2)

comment:1 Changed 3 years ago by Antoine Martin

Resolution: fixed
Status: newclosed

Indeed it is a typo, sorry about that - fixed in r11608. Closing.

comment:2 Changed 3 years ago by Antoine Martin

Summary: Latest Trunk Revision Is BrokenAttributeError in XpraServer: missing control_command_unlock_batck_delay
Note: See TracTickets for help on using tickets.