xpra icon
Bug tracker and wiki

#1095 closed enhancement (fixed)

support newer versions of TortoisePlink

Reported by: Antoine Martin Owned by: Smo
Priority: critical Milestone: 0.17
Component: platforms Version: trunk
Keywords: win32 Cc:

Description

for 2 reasons:

  • getting updates.. (security)
  • support for newer key exchange mechanisms

Downside: newer builds do not support XP

The plan: ship both versions and choose the appropriate one at runtime based on OS version detection (ie: use the old one for XP).

Attachments (1)

new-plink-as-default.patch (6.7 KB) - added by Antoine Martin 16 months ago.
uses the new plink as default, only tries to old one on XP

Download all attachments as: .zip

Change History (11)

comment:1 Changed 16 months ago by Antoine Martin

Status: newassigned

Mostly done in r11751 + r11753, but needs actual testing on win7 or later..

The env var XPRA_USE_NEW_PLINK can be used to force the use of the new plink (value "1") or disable it (value "0").
Otherwise we use the new plink (located in the new application subdirectory TortoisePlink) when we detect Windows version "5.x" or later.

Last edited 16 months ago by Antoine Martin (previous) (diff)

Changed 16 months ago by Antoine Martin

Attachment: new-plink-as-default.patch added

uses the new plink as default, only tries to old one on XP

comment:2 Changed 16 months ago by Antoine Martin

Owner: changed from Antoine Martin to Smo
Status: assignednew

I give up with the runtime approach above, the patch did not help, win32 is no cooperating and is just not helping me figure out why this does not work. (tried hacking the %PATH%, current working directory, etc..)

r11764 makes the NEW plink the default, r11765 uses the innosetup intaller to replace the new plink with the old XP-compatible one (and also shows a warning during installation).

We still ship the old Plink.exe in a TortoisePlink-XP sub-folder, this is used by the installer hack, and could be used for switching back to the old plink - should someone wish to do that (for whatever reason). Costs us about 1MB of disk space.

The updated build files rely on extra folders for plink, you will need:

  • A trimmed down version of the new plink from the latest tortoise svn installation (only installable on win7..):
    /e/Xpra-Build-Libs/TortoisePlink:
    total 2224
    drwxrwxrwt+ 1 XP_Pro None      0 Jan 27 20:32 .
    drwxrwxrwt+ 1 XP_Pro None      0 Jan 27 20:00 ..
    -rwxrwxrwx+ 1 XP_Pro None  18624 Dec 13 19:55 api-ms-win-core-file-l1-2-0.dll
    -rwxrwxrwx+ 1 XP_Pro None  18624 Dec 13 19:55 api-ms-win-core-file-l2-1-0.dll
    -rwxrwxrwx+ 1 XP_Pro None  21184 Dec 13 19:55 api-ms-win-core-localization-l1-2-0.dll
    -rwxrwxrwx+ 1 XP_Pro None  19136 Dec 13 19:55 api-ms-win-core-processthreads-l1-1-1.dll
    -rwxrwxrwx+ 1 XP_Pro None  19136 Dec 13 19:55 api-ms-win-core-synch-l1-2-0.dll
    -rwxrwxrwx+ 1 XP_Pro None  18624 Dec 13 19:55 api-ms-win-core-timezone-l1-1-0.dll
    -rwxrwxrwx+ 1 XP_Pro None  22720 Dec 13 19:55 api-ms-win-crt-convert-l1-1-0.dll
    -rwxrwxrwx+ 1 XP_Pro None  19136 Dec 13 19:55 api-ms-win-crt-environment-l1-1-0.dll
    -rwxrwxrwx+ 1 XP_Pro None  20672 Dec 13 19:55 api-ms-win-crt-filesystem-l1-1-0.dll
    -rwxrwxrwx+ 1 XP_Pro None  19648 Dec 13 19:55 api-ms-win-crt-heap-l1-1-0.dll
    -rwxrwxrwx+ 1 XP_Pro None  19136 Dec 13 19:55 api-ms-win-crt-locale-l1-1-0.dll
    -rwxrwxrwx+ 1 XP_Pro None  29376 Dec 13 19:55 api-ms-win-crt-math-l1-1-0.dll
    -rwxrwxrwx+ 1 XP_Pro None  26816 Dec 13 19:55 api-ms-win-crt-multibyte-l1-1-0.dll
    -rwxrwxrwx+ 1 XP_Pro None  23232 Dec 13 19:55 api-ms-win-crt-runtime-l1-1-0.dll
    -rwxrwxrwx+ 1 XP_Pro None  24768 Dec 13 19:55 api-ms-win-crt-stdio-l1-1-0.dll
    -rwxrwxrwx+ 1 XP_Pro None  24768 Dec 13 19:55 api-ms-win-crt-string-l1-1-0.dll
    -rwxrwxrwx+ 1 XP_Pro None  21184 Dec 13 19:55 api-ms-win-crt-time-l1-1-0.dll
    -rwxrwxrwx+ 1 XP_Pro None  19136 Dec 13 19:55 api-ms-win-crt-utility-l1-1-0.dll
    -rwxrwxrwx+ 1 XP_Pro None 439608 Dec 13 19:55 msvcp140.dll
    -rwxrwxrwx+ 1 XP_Pro None 400768 Dec 13 23:23 TortoisePlink.exe
    -rwxrwxrwx+ 1 XP_Pro None 921280 Dec 13 19:55 ucrtbase.dll
    -rwxrwxrwx+ 1 XP_Pro None  85328 Dec 13 19:55 vcruntime140.dll
    
  • the old tortoise plink installation (ie: latest tortoisesvn 1.8 builds):
    /e/Xpra-Build-Libs/TortoisePlink-XP:
    total 1756
    drwxrwxrwt+ 1 XP_Pro None      0 Jan 24 22:27 .
    drwxrwxrwt+ 1 XP_Pro None      0 Jan 27 20:00 ..
    -rwxrwxrwx+ 1 XP_Pro None 535008 Nov  6  2012 msvcp110.dll
    -rwxrwxrwx+ 1 XP_Pro None 875472 Nov  6  2012 msvcr110.dll
    -rwxrwxrwx+ 1 XP_Pro None   1318 Dec 10  2011 Putty-LICENSE.txt
    -rwxrwxrwx+ 1 XP_Pro None 379776 Mar 19  2015 TortoisePlink.exe
    

@smo: over to you to update your build systems, then please re-assign to afarr so we can check that this doesn't break anything


The new alert box can be skipped by executing the build with:

win32\PY27_MSVC_BUILD.BAT /SILENT /SUPPRESSMSGBOXES

(the same flags are passed to the .exe installer)

Last edited 16 months ago by Antoine Martin (previous) (diff)

comment:3 Changed 16 months ago by Antoine Martin

Breaks Windows Vista, see #1117.

comment:4 Changed 16 months ago by Antoine Martin

The correct file list can be found here: ticket:1117#comment:5.

@smo: update your build machine then please close. (feel free to test on Vista / win10 / whatever)

comment:5 Changed 14 months ago by Smo

Owner: changed from Smo to Antoine Martin

I've updated to tortoisesvn 1.8 since 1.9 can't install on windows XP is this correct if so this is working.

comment:6 Changed 14 months ago by Antoine Martin

Owner: changed from Antoine Martin to Smo

@smo: no, see comment:2 : A trimmed down version of the new plink from the latest tortoise svn installation (only installable on win7..).
You need to grab the installation directory from a win7 system - 1.9 won't install on XP, but we need 1.9 to get the patched plink.

comment:7 Changed 14 months ago by Antoine Martin

Priority: majorcritical

Should be easy to test: XP should work as before (and show a warning during installation) and use the older plink, win7 onwards should have the newer plink installed.

comment:8 Changed 13 months ago by Smo

Owner: changed from Smo to Antoine Martin

Tortoisesvn 32bit installation doesn't allow installing it on Windows7 64 bit with error message.

You are attempting to run the 32-bit installer on a 64-bit
version of Windows. Please install the 64-bit version of
TortoiseSVN instead.

I need to get this installed on a 32 bit system but I don't have any handy.

If this works for you I suggest we just close this instead of waiting for me.

comment:9 Changed 13 months ago by Antoine Martin

Owner: changed from Antoine Martin to Smo

@smo: afarr has got one. That's how I got mine.

You need this working because you may need to use the SSH transport when testing stuff.

comment:10 Changed 13 months ago by Smo

Resolution: fixed
Status: newclosed

This is working and I get the warning on windows xp

Note: See TracTickets for help on using tickets.