#1136 closed enhancement (fixed)
move websockify in the xpra process
Reported by: | Antoine Martin | Owned by: | alas |
---|---|---|---|
Priority: | major | Milestone: | 1.0 |
Component: | server | Version: | trunk |
Keywords: | Cc: |
Description
So we don't have to exec anything, then we also won't be needing the proxy instance running xpra side (which is forwarding to and from the websockify process, using 2 threads).
See also #1134.
Attachments (2)
Change History (10)
comment:1 Changed 5 years ago by
Milestone: | 0.17 → 0.18 |
---|---|
Status: | new → assigned |
Changed 5 years ago by
Attachment: | websockify-inprocess.patch added |
---|
comment:2 Changed 5 years ago by
The patch above works fine, only left todo:
- handle
html=/path/to/www
and generate / detect correct path (ie: on osx, in the app bundle) - TLS setup
- man page updates
- test tcp-proxy mode better
- use the peek function to avoid creating a whole protocol instance (and threads) if the packet header is invalid
- verify blocking sockets and timeout values
comment:3 Changed 5 years ago by
Mostly done in r12688. Firefox is still having problems, but that doesn't seem to be anything new.
Still todo:
- TLS
- bail out early on invalid packet header
Changed 5 years ago by
Attachment: | web-ssl.patch added |
---|
attempts at preventing ssl from deadlocking - failed
comment:4 Changed 5 years ago by
Owner: | changed from Antoine Martin to alas |
---|---|
Status: | assigned → new |
- r12708 fixes an error with win32 servers (but win32 servers still don't support the html5 client: #1211)
- r12699 bails out early
- I give up on SSL for now - will follow up in #1213, the patch above tries to use a thread as early as possible, setting timeouts on the sockets, raising the number of sockets we create, etc.. to no avail
@afarr: the html client should be faster now
comment:5 Changed 5 years ago by
HTML client is by far faster. It's like night and day faster now.
I'd say performance in Chrome is 90% as good as Python.
comment:6 Changed 5 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Oh, sorry, I hit submit without thinking.
Closing.
comment:8 Changed 4 days ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/1136
Note: See
TracTickets for help on using
tickets.
move websockify handling in process