We've been talking about this one a bit recently, and we've gathered all necessary data to finally open a ticket.
The repro is fairly straightforward:
XPRA_OPENGL_PAINT_BOX=1enabled optionally, does help to visualize what's going on
The video starts getting tearing due a partial repaint over the h264 region.
I'll attach a screenshot, a short video, and the requested Xpra Info.
Also, I'm marking this as client, but I'm not sure if that's where the issue is lying. All of this was done with latest trunk r12735 on Fedora 23 (both machines) 64-bit.
Requested Xpra info
A quick video documenting what we're seeing
A screenshot depicting the partial painting over the video region
(update title, we see this in a few spots, but YouTube? is the easiest to repro with Chrome)
Found the bugs: if we are processing the video frames sufficiently fast, the window damage events for the other bits (widgets, progress bar, etc) may arrive whilst there are no video damage events queued up, we then decide that the update is not video as it is not worth sending the whole area as video since it is only a small portion of it.
There were actually two bugs here, both fixed by r12744. This will be backported.
Note: this is going to be worse when we have av-sync on. The widgets will now get repainted with the video, which is delayed for av-sync.. And if they only partially overlap the video, only half will be delayed.
Upped my client and server to r12754:
I am now seeing some really peculiar painting issues while using Firefox. When typing or highlighting text, nothing appears to update until I scroll within the webpage. It's like it's not partially repainting properly. I assume it's because of the fixes for this ticket. I'll attach a quick recording to demonstrate.
But, I no longer see the region tearing with video controls.
Of course, if it's unrelated to this, it can go into a new ticket.
I also see this issue in Chrome. Playing a video seems to avoid the issue entirely.
I have tested this on my dev box, then built new beta packages then tested in all the Fedora vms that I have and I cannot reproduce this problem at all. Are you sure that this is caused by this changeset? Have you tried any other versions to compare?
I can only guess that you are doing something different than I am. Having xpra info or at the very least, the command lines you've used would help. Maybe you're enabling opengl on a buggy chipset? If that's the case, it could help us fix it as the effects seem quite dramatic. (new ticket, please include opengl paint boxes, opengl debug, etc)
Maybe you're enabling opengl on a buggy chipset?
Oddly enough I'm getting it with OpenGL off as well. Either way, this machine has an Nvidia 745, so OpenGL shouldn't be a problem. Well...maybe. It is Nvidia after all....
Server start commands:
xpra start :13 --bind-tcp=0.0.0.0:2200 --start-new-commands=yes --start-child=xterm --start-child="xterm -bg black -cr white -fg white" --start-child="xterm -bg black -cr white -fg white"
xpra attach tcp:ip:port
So nothing special, really. Just a TCP server with a couple Xterms.
Either way the issues I'm seeing for this ticket are resolved, so since you can't repro what I'm seeing now, I'll go ahead and close this one (again, video controls no longer tear video) and file a new one after some further investigation.
I've been unable to reproduce Max's issue.. I think what he saw might be unrelated to this fix.
when we exclude non-video regions from the window paint, make sure they eventually get refreshed too
Please confirm that the original bug is still fixed and that the regression in #1225 is also gone.
re-closing this ticket as fixed.
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/1218