xpra icon
Bug tracker and wiki

Opened 18 months ago

Closed 18 months ago

Last modified 13 months ago

#1227 closed enhancement (fixed)

clarify encoders and muxers in sound codec short names

Reported by: Antoine Martin Owned by: alas
Priority: major Milestone: 1.0
Component: core Version: trunk
Keywords: sound codecs Cc:

Description

When codecs were first added, there was no support for multiple muxers, but now there is...
And it makes sense to use the full specification including the muxer in the codec name, so we have to switch to the new full-name and preserve backwards compatibility.

ie: vorbis will now be called vorbis+gdp and flac will now be called flac+ogg, but older clients and servers should still be able to use the old names when connecting to newer versions of xpra.

Somewhat related to #1204.


Similar to what we did for picture encodings when we switched from the old names (x264, vpx) to the new ones (h264, vp8, vp9), translate and only use the new names internally: we must send both in hello packets in case the other end doesn't understand the new names and when parsing the data (either from the command line or from a hello packet) we convert to the new names.

Change History (4)

comment:1 Changed 18 months ago by Antoine Martin

Owner: changed from Antoine Martin to alas

Done in r12801 + r12802.

The new codecs names can be seen using xpra/sound/gstreamer_util.py, on session info and with the xpra start --speaker-codec=help / xpra start --microphone-codec=help command lines.. (and also with "attach")

If I've messed this up, it is possible that older clients or servers will be missing some codecs when they negotiate what codec to use, or worse they could fail when processing sound requests or sound packets. Tested OK here.

@afarr: this is mostly a FYI, though it wouldn't hurt to make sure that we keep backwards compatibility with older versions (0.17.x and earlier), at least for the most commonly used codecs which have been renamed by this change: vorbis -> vorbis+gdp, flac -> flac+ogg, opus -> opus+ogg, speex -> speex+ogg.

comment:2 Changed 18 months ago by J. Max Mena

Resolution: fixed
Status: newclosed

Noted, meant to close this a while back.

I did test a 17.4 client (from /dists) against an 18.X trunk server built from source and all seemed okay. Sound was working just fine.

Closing.


Finally got that song out of my head.......

comment:3 Changed 17 months ago by Antoine Martin

Milestone: 0.181.0

Milestone renamed

comment:4 Changed 13 months ago by Antoine Martin

A few codecs were (re-)added and the compatibility code tweaked in r14401.

Hopefully this doesn't cause any regressions.. The new codecs were added at the end of the list anyway.

Note: See TracTickets for help on using tickets.