xpra icon
Bug tracker and wiki

Opened 10 months ago

Closed 8 months ago

Last modified 4 months ago

#1247 closed enhancement (fixed)

start-desktop using a single display

Reported by: Antoine Martin Owned by: Antoine Martin
Priority: minor Milestone: 1.0
Component: server Version: trunk
Keywords: full desktop x11 Cc:

Description

Follow up from #1206.

Instead of starting Xephyr nested in a mostly unused Xvfb display, we should be able to start the Xvfb and watch the root window directly for damage events.

This should work without having to enable the Composite extension, without redirecting any windows, which would be more compatible with some rendering mechanisms which are not currently supported, notably some multi display native graphics card modes.
We would not need to run as window manager on the vfb display at all, simplifying the code greatly (no need for focus management, etc - just direct mouse and keyboard events).

Attachments (2)

nocomposite.patch (11.7 KB) - added by Antoine Martin 10 months ago.
poc patch showing the root window as a managed window
start-desktop-nocomposite.patch (40.5 KB) - added by Antoine Martin 10 months ago.
much better approach using a dedicated model and server class

Download all attachments as: .zip

Change History (9)

Changed 10 months ago by Antoine Martin

Attachment: nocomposite.patch added

poc patch showing the root window as a managed window

Changed 10 months ago by Antoine Martin

much better approach using a dedicated model and server class

comment:1 Changed 10 months ago by Antoine Martin

Status: newassigned

Some preparatory refactoring which also helps in more clearly separating the gtk code and pure x11 code: r12970 (cursor, clobber flag), r12971 (windows vs cursors), r12973 (bell, motion, cursors).

Things left to do:

  • fixup focus and click events
  • replace the desktop manager: each client may map the desktop window where it wants so we need per-client window position (related to #41 and shadow servers which also need to adjust the window position when processing mouse events)
  • handle multiple displays as individual windows (xinerama / randr) - or even join them up / split them! (see also #1009)
  • hookup randr signals, maybe allow the client to resize via randr from the tray, or even send the list of resolutions that can be used and allow window resizing with size constraints
  • expose more x11 properties: session name, etc.
  • extract what we need from composite helper - no composite needed!
  • screenshot code: re-use shadow code?
  • window control arbitration: only one owner at a time (maybe just one session owner at a time)
Last edited 10 months ago by Antoine Martin (previous) (diff)

comment:2 Changed 10 months ago by Antoine Martin

More preparatory work in r12974 (randr cleanup), r12975 + r12976 (mouse pointer adjustments: re-use shadow code), r12977 (window model class refactoring), r12978 (split damage from composite), r12979 (fix undedirect), r12980 (logging tweak), r12982 (unnecessary import fixup)

Full "start-desktop" support added in r12981 + r12983, see commit message for details.

Still TODO:

  • xrandr corrupts the window
  • screenshot code
  • multi-display handling (see comment:1 above)
  • maybe make the initial display resolution configurable via command line switch instead of XPRA_DEFAULT_VFB_RESOLUTION (#1132)
  • screen refresh issues: we use h264 too aggressively
Last edited 7 months ago by Antoine Martin (previous) (diff)

comment:3 Changed 10 months ago by Antoine Martin

Turns out that the corrupted window with resizing may well be an Intel opengl issue (#1233), and it should work well enough as of r12986, will need to re-test on non-intel chipsets.

For reference, here's how you can easily start a non-composited vfb:

xpra start-desktop \
    --xvfb='Xvfb -extension Composite -nolisten tcp -noreset -auth $XAUTHORITY -screen 0 1920x1080x24+32'

Another option is to use an existing display server with xpra start-desktop --use-display.

This mode may be useful for adding support for deep colour modes (#909).

Last edited 7 months ago by Antoine Martin (previous) (diff)

comment:4 Changed 10 months ago by Antoine Martin

Milestone: 0.181.0

Milestone renamed

comment:5 Changed 8 months ago by Antoine Martin

Some minor updates:

  • r13577: start with the default screen size (1080p), don't resize to match the client (+ minor fix in r13581)
  • r13580: server screen layout detection and logging
  • r13578: support for screenshot command (captures all screens)
  • r13582: try to send pointer events to the right screen when we start the vfb with more than one screen, ie using:
    xpra start-desktop :20 --start=xterm \
        --xvfb='Xvfb -extension Composite -nolisten tcp -noreset -auth $XAUTHORITY \
            -screen 0 1920x1080x24+32 \
            -screen 1 1920x1080x24+32'
    

Unfortunately, there is an Xorg bug which sends all events to the first screen: XTestFakeMotionEvent no longer works on multiple screen displays


@afarr: just a FYI, please close.

comment:6 Changed 8 months ago by alas

Resolution: fixed
Status: assignedclosed

Noted... to the best of my ability.

Closing.

comment:7 Changed 4 months ago by Antoine Martin

Added wiki page: wiki/Desktop.

Note: See TracTickets for help on using tickets.