xpra icon
Bug tracker and wiki

Opened 4 years ago

Closed 4 years ago

#1262 closed defect (fixed)

Unexpanded tilde in Xorg log filename

Reported by: dtaylor84 Owned by: dtaylor84
Priority: critical Milestone: 1.0
Component: server Version: trunk
Keywords: Cc:

Description (last modified by Antoine Martin)

I recently upgraded from Debian jessie to stretch, and started having problems with xpra (version 1.0-20160715r13017).

I have managed to solve the problem by adding a line to /etc/xpra/xpra.conf:

xvfb=Xorg -dpi 96 -noreset -nolisten tcp +extension GLX +extension RANDR +extension RENDER -auth $XAUTHORITY -logfile ${HOME}/.xpra/Xorg.${DISPLAY}.log -configdir ${HOME}/.xpra/xorg.conf.d -config /etc/xpra/xorg.conf

Where I changed the (only) tilde in the default command to ${HOME}: i.e. -logfile ~/.xpra/Xorg.${DISPLAY}.log to -logfile ${HOME}/.xpra/Xorg.${DISPLAY}.log.

Without this change strace shows Xorg attempting to literally open ~/.xpra/Xorg.:nn.log, which fails. I was unable to track down where the tilde-expansion was previously happening, and as the other arguments already use ${HOME}, it seems a simple fix.

Change History (4)

comment:1 Changed 4 years ago by Antoine Martin

Description: modified (diff)
Priority: majorcritical
Status: newassigned

Thanks for the report.

That's odd, build_xpra_conf gets the value for xvfb_command from detect_xorg_setup which uses:

        log_dir = get_default_log_dir().replace("~/", "${HOME}/")

So the default config in the packages should have the correct value already.

I'll have to play with this in a Debian VM next week.

comment:2 Changed 4 years ago by Antoine Martin

@dtaylor84: I've just tried on Jessie and couldn't see the problem, either with the package or with a source install.

Then on stretch, it's badly broken. Somehow the config files (there are many now: #1254) have no substitutions in them at all!?

comment:3 Changed 4 years ago by Antoine Martin

Owner: changed from Antoine Martin to dtaylor84
Status: assignednew

No idea how stretch gets confused like this, or why r13192 fixes it - but it does...

beta packages are available.

@dtaylor84: does that work for you?
You may need to purge the previous config files. If you have the beta repo installed:

apt-get remove xpra && apt-get purge xpra && apt-get install xpra
Last edited 4 years ago by Antoine Martin (previous) (diff)

comment:4 Changed 4 years ago by dtaylor84

Resolution: fixed
Status: newclosed

Ah, somehow I missed the existence of /etc/xpra/conf.d/, the *.in files being there at least explains why things are going wrong.

I can't say I entirely understand how that results in this particular problem, or why it started happening in stretch, but I can confirm the current beta package is working correctly for me.

Thanks for the swift resolution!

Note: See TracTickets for help on using tickets.