xpra icon
Bug tracker and wiki

Opened 17 months ago

Closed 3 weeks ago

#1312 closed enhancement (fixed)

avoid clipboard loops when running nested / sharing sessions

Reported by: Antoine Martin Owned by: J. Max Mena
Priority: minor Milestone: 2.3
Component: clipboard Version: trunk
Keywords: Cc:

Description (last modified by Antoine Martin)

Related to #41.

Create a UUID for each clipboard helper and add it to a root window property. Clients and servers forward their list of UUIDs to the other end, which then adds those to the root window property.
If any duplicates are found, we have a loop.

Another way of dealing with this is to set a random token on startup, prevent this token from ever being sent across, then looking for it at the other end. Any other clipboard synchronization tool will copy it, then we know we have a loop.

Attachments (1)

clipboard-loops.patch (6.6 KB) - added by Antoine Martin 17 months ago.
work in progress patch

Download all attachments as: .zip

Change History (6)

Changed 17 months ago by Antoine Martin

Attachment: clipboard-loops.patch added

work in progress patch

comment:1 Changed 3 weeks ago by Antoine Martin

Description: modified (diff)
Milestone: future2.3
Status: newassigned

comment:2 Changed 3 weeks ago by Antoine Martin

Done in r18229 (see commit message): we use a token which is never forwarded, then check for its presence at the other end.

Still TODO:

  • notifications: #1688
  • maybe clear the magic token after we have verified at the other end
Last edited 3 weeks ago by Antoine Martin (previous) (diff)

comment:3 Changed 3 weeks ago by Antoine Martin

Notifications and more done in r18230.

Keeping this ticket assigned to me as I have seen shadow server hangs in the clipboard code, which may be caused / made worse / related to this.

comment:4 Changed 3 weeks ago by Antoine Martin

Owner: changed from Antoine Martin to J. Max Mena
Status: assignednew

Crashes and other problems should be gone as of r18248.

@maxmylyn: this ticket should ensure that we can coexist with other clipboard synchronization tools (ie: virtualbox, synergy, etc) and deal with it much more gracefully: disabling the clipboard and showing a notification to the user. Feel free to close.

comment:5 Changed 3 weeks ago by J. Max Mena

Resolution: fixed
Status: newclosed

Excellent - noted.

Closing

Note: See TracTickets for help on using tickets.