xpra icon
Bug tracker and wiki

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#136 closed defect (fixed)

Please get setup.py to install xpra_launcher.1 manpage

Reported by: أحمد المحمودي Owned by: Antoine Martin
Priority: major Milestone: 0.3
Component: android Version: 0.3.x
Keywords: Cc:

Description (last modified by Antoine Martin)

Hello,

The desktop launcher xpra_launcher.desktop has those fields:

Exec: xpra_launcher
TryExec: xpra_launcher

although setup.py actually installs xpra_launcher as xpra:

    scripts=["scripts/parti", "scripts/parti-repl",
             "scripts/xpra", "scripts/xpra_launcher",
            ]

The attached patch corrects the name of the executable to 'xpra'.

Attachments (2)

xpra_launcher.diff (436 bytes) - added by أحمد المحمودي 7 years ago.
xpra_0.3.2+dfsg-1.debian.tar.gz (6.9 KB) - added by أحمد المحمودي 7 years ago.
Latest debian packaging

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by أحمد المحمودي

Attachment: xpra_launcher.diff added

comment:1 Changed 7 years ago by Antoine Martin

Description: modified (diff)
Resolution: fixed
Status: newclosed

Sorry, but this is not the case, the distutils setup.py installs both.
And the one to run from the UI is xpra_launcher, so everything is correct as far as I can tell.

As for packaging, I can see it in the rpm specfile:

%{_bindir}/xpra_launcher

But it was missing from the debian xpra.install file, this is fixed in r885 (will backport to 0.3 branch)

Last edited 7 years ago by Antoine Martin (previous) (diff)

comment:2 Changed 7 years ago by أحمد المحمودي

Resolution: fixed
Status: closedreopened
Summary: Correct the name of executable to run in desktop launcherPlease get setup.py to install xpra_launcher.1 manpage

I see, thanks for the explanation.

In that case, I think that setup.py should also install xpra_launcher.1 manpage.

comment:3 Changed 7 years ago by Antoine Martin

Resolution: fixed
Status: reopenedclosed

good catch!

done in r893 for both trunk and v0.3 branch

comment:4 Changed 7 years ago by Antoine Martin

see also r899

Note: if you make any changes to your copy of the /debian/ package files, please let me know so my packages don't end up diverging too much.

Changed 7 years ago by أحمد المحمودي

Latest debian packaging

Note: See TracTickets for help on using tickets.