xpra icon
Bug tracker and wiki

Opened 14 months ago

Last modified 3 weeks ago

#1375 new enhancement

User should be notified when a file is uploaded from the server

Reported by: ERIC GRAMMATICO Owned by: ERIC GRAMMATICO
Priority: major Milestone: 2.3
Component: client Version: trunk
Keywords: Cc:

Description

When a file is uploaded from the server to the client application, there is only a notification in the client logs. This is not sufficient and could lead to a security issue in case of the server is compromised. The client host could be flooded silently.

The user should be:
1/ Asked to accept the upload
2/ Notified through system-tray or popup

Thanks and regards,

Eric.

Change History (7)

comment:1 Changed 14 months ago by ERIC GRAMMATICO

2/ Notified through system-tray or popup when upload done.

comment:2 Changed 11 months ago by Antoine Martin

Milestone: 2.2
Status: newassigned

comment:3 Changed 3 months ago by Antoine Martin

Milestone: 2.23.0

re-scheduling

comment:4 Changed 2 months ago by Antoine Martin

See #1688

comment:5 Changed 8 weeks ago by Antoine Martin

Milestone: 3.02.3

comment:6 Changed 4 weeks ago by Antoine Martin

Client-side GUI for accepting "print", "file-transfers" or "open file" requests has been added in r17740.
The new default for "file-transfers" and "open-files" options is "auto", which will prompt GUI users.

Still TODO:

  • usual py3k fixes..
  • #1726: enable "open-on-client" by default? add "open-url"?
  • improve the dialog: add details about the file (size, mimetype?) and a countdown timer since the other end will eventually give up (and we know how long we have), maybe support multiple uploads in the same dialog? (in a table view)
  • we could also add a new "open-on-server" option so that the user can choose where the link / file is opened, telling the server to fallback to the regular xdg-open
  • maybe: support "ask" on the server side? At the moment, the server can only be set to on or off, not sure it makes sense to popup a dialog since this would go to the user that requested the upload in the first place..
  • the notification part is best dealt with in #1492
  • maybe offer the option to override "open-with"
Last edited 4 weeks ago by Antoine Martin (previous) (diff)

comment:7 Changed 3 weeks ago by Antoine Martin

Owner: changed from Antoine Martin to ERIC GRAMMATICO
Status: assignednew

Done:

This should be enough for this release.

Still TODO / possible improvements:

  • hard-coded /usr/bin/xdg-open - meh
  • could add option to "download-only" for files that are sent to be opened (would need a new message to the server to toggle the open flag to false, and update our cached verification copy too - meh)
  • the same dialog could be used to show file-transfers in progress (update progress percentage with each chunk received) - and maybe show this dialog automatically for uploads / downloads that take more than a couple of seconds
  • we should honour the bandwidth-limit in chunked transfers
  • could skip the download if we find an existing file with the same name and same checksum

Beta builds with this feature can be found here: https://xpra.org/beta/
@ERIC GRAMMATICO: does that work for you?

Note: See TracTickets for help on using tickets.