xpra icon
Bug tracker and wiki

Opened 3 years ago

Closed 3 years ago

#1379 closed defect (fixed)

Missing import in xpra/codecs/webp/encode.pyx

Reported by: jonathan.underwood Owned by: Antoine Martin
Priority: major Milestone:
Component: android Version: trunk
Keywords: Cc:

Description

xpra-1.0 fails to build, complaining about this:

Compiling xpra/net/ben
Error compiling Cython file:
------------------------------------------------------------
...
import os

from xpra.log import Logger
log = Logger("encoder", "webp")

from xpra.util envbool
              ^
------------------------------------------------------------

xpra/codecs/webp/encode.pyx:11:15: Expected 'import' or 'cimport'
code/cython_bencode.pyx because it changed.
Compiling xpra/net/vsock.pyx because it changed.

Patch attached (trivial).

Attachments (1)

xpra-1.0-webp-encode-fix-import.patch (517 bytes) - added by jonathan.underwood 3 years ago.

Download all attachments as: .zip

Change History (2)

Changed 3 years ago by jonathan.underwood

comment:1 Changed 3 years ago by Antoine Martin

Resolution: fixed
Status: newclosed

Thanks, applied to v1.0.x in r14524.

Note: all the packages we build have had webp disabled and webp support has now been removed in trunk as of r14508, together with csc_opencl and csc_opencv.
That's because:

  • loading our own build of webp (since #613) was causing too many problems: conflicts with python pillow loading the system one, performance differences between different versions and platforms, etc
  • opencl is buggy (see AMD opencl icd signal dispatch bugs)
  • opencv csc was too slow
Note: See TracTickets for help on using tickets.