Xpra: Ticket #1393: omit "-p" option to ssh if port not specified

xpra is now always supplying a "-p" option to ssh to specify the port number (using "-p 22" if not provided).

However, this prevents the use of standard ssh configuration options in ~/.ssh/config where a host's port number can be specified for standard (no-port-specified) ssh commands.

If a ssh connect string contains no port number, xpra should actually omit the "-p" option altogether, allowing ssh itself to properly choose the port for the given hostname (which of course will default to 22 if not otherwise configured). This parallels other standard usage of ssh as a tunneling protocol in other applicaitons.

Sat, 31 Dec 2016 04:39:11 GMT - Antoine Martin: status changed; resolution set

Fixed in r14667 for trunk, backport to v1.0.x in rr14668.

PS: I think that was the case before and that the parse_host_string refactoring lost that. (as the mostly duplicated launcher code still has it..)

Sat, 23 Jan 2021 05:23:01 GMT - migration script:

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/1393