xpra icon
Bug tracker and wiki

Opened 4 months ago

Last modified 3 months ago

#1443 new defect

restore get_depth in pygtkglext OSX patch

Reported by: Antoine Martin Owned by: Smo
Priority: major Milestone: 2.1
Component: platforms Version: trunk
Keywords: opengl osx Cc:


When coercing pygtkglext to build on OSX (see ticket:533#comment:25), we removed the "get_depth" function which we did not use.
We do need it now for high bit depths.. see ticket:1309#comment:2.
So we need to find a way to restore it and make it work.

Change History (2)

comment:1 Changed 4 months ago by Antoine Martin

Status: newassigned

r15094 worksaround the missing method so the opengl rendering will be enabled - but we won't know if the display is using a high bit depth.

comment:2 Changed 3 months ago by Antoine Martin

Owner: changed from Antoine Martin to Smo
Status: assignednew

Implemented in gtkglext then restored the function which exposes it in pygtkglext: r15375.
Just run:

jhbuild buildone -f gtkglext
jhbuild buildone -f pygtkglext

Tested on a 24-bit display, which now shows "depth : 24" when running the "OpenGL_check" tool. (previously, no value was shown)

@smo: do you have access to any macos system with high bit depth enabled?
Not sure what graphics cards and / or monitor are required (but the mac mini I have sure isn't cutting it), it should look like this: 4K and 5K iMacs Support 10-Bit Color Depth on OS X El Capitan.
If you can find a system that shows anything higher than 24, or even any value other than 24 (low bit depths should work too), then please post the OpenGL_check output and try to run the client - ideally against a 30-bit server (see wiki/ImageDepth).

Note: See TracTickets for help on using tickets.