xpra icon
Bug tracker and wiki

Opened 2 months ago

Closed 2 months ago

#1474 closed defect (fixed)

Server hangs

Reported by: JAremko Owned by: JAremko
Priority: major Milestone: 2.1
Component: server Version: trunk
Keywords: Cc:

Description

Reproduction:
Run Xpra server with no sharing and with --exit-with-client=yes and connect to it with two (in rapid succession) unmodified HTML5 clients.
You'll get something like this:

2017-03-27 12:59:50,686 Handshake complete; enabling connection
2017-03-27 12:59:50,805 HTML5 Linux client version 2.1
2017-03-27 12:59:50,805  automatic picture encoding enabled
2017-03-27 12:59:50,805  also available:
2017-03-27 12:59:50,805   jpeg, png, rgb32
2017-03-27 12:59:50,805  client root window size is 1920x1014 with 1 display:
2017-03-27 12:59:50,806   HTML (508x268 mm - DPI: 96x96)
2017-03-27 12:59:50,806     Canvas
2017-03-27 12:59:50,808 setting keyboard layout to 'us'
2017-03-27 12:59:51,397 client 1: got hello: server version 2.1 accepted our connection
2017-03-27 12:59:51,398 client 1: startup complete
2017-03-27 12:59:52,657 Handshake complete; enabling connection
2017-03-27 12:59:52,657 Disconnecting client 172.17.0.1:60352:
2017-03-27 12:59:52,657  new client (this session does not allow sharing)
2017-03-27 12:59:52,658 xpra client 1 disconnected.
2017-03-27 12:59:52,660 HTML5 Linux client version 2.1
2017-03-27 12:59:52,660  automatic picture encoding enabled
2017-03-27 12:59:52,660  also available:
2017-03-27 12:59:52,660   jpeg, png, rgb32
2017-03-27 12:59:52,660 Last client has disconnected, terminating
2017-03-27 12:59:52,660 xpra is terminating.
2017-03-27 12:59:52,686  client root window size is 1920x1014 with 1 display:
2017-03-27 12:59:52,686   HTML (508x268 mm - DPI: 96x96)
2017-03-27 12:59:52,686     Canvas
2017-03-27 12:59:52,687 keyboard mapping already configured (skipped)
2017-03-27 12:59:52,716 client 2: got hello: server version 2.1 accepted our connection
2017-03-27 12:59:52,717 client 2: startup complete

then server should hang.

Change History (3)

comment:1 Changed 2 months ago by Antoine Martin

Milestone: future2.1
Priority: minormajor
Status: newassigned

comment:2 Changed 2 months ago by Antoine Martin

Owner: changed from Antoine Martin to JAremko
Status: assignednew

It's tricky to make sure that we never get any race conditions between accepting new connections and shutting down the server, but at least this particular case should be fixed in r15452. (more in r15453)

Last edited 2 months ago by Antoine Martin (previous) (diff)

comment:3 Changed 2 months ago by JAremko

Resolution: fixed
Status: newclosed

Thanks!

Note: See TracTickets for help on using tickets.