xpra icon
Bug tracker and wiki

Opened 3 weeks ago

Closed 5 days ago

Last modified 5 days ago

#1513 closed defect (fixed)

"--without-service" does not stop Xpra from writing files to /usr/lib

Reported by: Jens H. Goebbert Owned by: Jens H. Goebbert
Priority: major Milestone: 2.1
Component: android Version: trunk
Keywords: Cc:

Description (last modified by Antoine Martin)

Hello,

we updated lately to Xpra 1.0.5 using the install option "--without-service" on our system (without root permissions).
Currently we need to patch Xpra as it tries to write to the system directory /usr/lib or /lib in setup.py and fails:

1514	        #not supported by all distros, but doesn't hurt to install it anyway:
1515	        prefix = "/usr/lib"
1516	        from xpra.os_util import is_Fedora, is_CentOS
1517	        if is_Fedora() or is_CentOS():
1518	            prefix = "/lib"
1519	        add_data_files("%s/tmpfiles.d" % prefix, ["tmpfiles.d/xpra.conf"])
1520	        add_data_files("%s/sysusers.d" % prefix, ["sysusers.d/xpra.conf"])

Can you change setup.py that way, that it avoids this if installed with --without-service.

This is related to the ticket: #1383

Best,
Jens Henrik

Change History (3)

comment:1 Changed 3 weeks ago by Antoine Martin

Description: modified (diff)
Milestone: 1.12.1
Owner: changed from Antoine Martin to Jens H. Goebbert

You are claiming to be building 1.0.5, but the sysusers.d files are only present in trunk..

In any case, the correct fix for this is in r15797 (minus the nvfbc part at the end I committed by mistake), but this change is a little bit too big to backport to the 1.0 branch.

Not shipping tmpfiles.d when building with --without-service is not a good solution either as those two features are unrelated.

So I am tempted to just schedule it for 1.1 and close this ticket.

@Jens H. Goebbert: does that work for you?

comment:2 Changed 5 days ago by Antoine Martin

Resolution: fixed
Status: newclosed

Not heard back, closing.

comment:3 Changed 5 days ago by Jens H. Goebbert

Hi Antoine,

I could not test your patch yet, sorry, but your patch reads good. Thanks.

Best,
Jens Henrik

Note: See TracTickets for help on using tickets.