xpra icon
Bug tracker and wiki

Opened 4 months ago

Closed 4 months ago

#1582 closed defect (worksforme)

User config ignored if started via proxy

Reported by: psycho_zs Owned by: psycho_zs
Priority: major Milestone: 2.1
Component: server Version: trunk
Keywords: Cc:

Description

using 2.1-20170715r16357-1, when server is started via system service, user config is ignored. When starting with --start-via-proxy=no, user config is successfully applied.

Change History (5)

comment:1 Changed 4 months ago by Antoine Martin

Status: newassigned

Good catch!
(related to #1105)

comment:2 Changed 4 months ago by Antoine Martin

Owner: changed from Antoine Martin to psycho_zs
Status: assignednew

Seems fixed in r16382.

(unfortunately, we have to whitelist the options that do get forwarded so it is possible I've missed one)

comment:3 Changed 4 months ago by psycho_zs

Haven't tested yet, but there are options I didn't find in PROXY_START_OVERRIDABLE_OPTIONS:

key-shortcut, env, desktop-scaling, dpi

comment:4 Changed 4 months ago by Antoine Martin

Options like key-shortcut, desktop-scaling are only used by the client so they don't need to be forwarded.
dpi: the client will forward it to the server on connection, which is a little bit different admittedly, so r16384 fixes that.
env and start-env added in r16383.

comment:5 Changed 4 months ago by Antoine Martin

Resolution: worksforme
Status: newclosed

Important fix as part of r16502 (for #1105 mostly): we don't want to honour env when running as root. A user could potentially use this to subvert the system wide proxy service.

Closing, feel free to re-open if I've missed something.

Note: See TracTickets for help on using tickets.