xpra icon
Bug tracker and wiki

Opened 19 months ago

Closed 19 months ago

Last modified 19 months ago

#1647 closed enhancement (fixed)

Forwarding original app name in notifications

Reported by: psycho_zs Owned by: psycho_zs
Priority: minor Milestone: 2.2
Component: client Version: trunk
Keywords: libnotify Cc:

Description

Please consider supporting forwarding original notification app name (the field represented by notify-send -a ).

Currently all forwarded notifications have 'Xpra' as their application name. Might be handy if it would read $ORIGINAL_APPNAME (on $REMOTE_HOSTNAME), akin how window managers name remote windows.

Change History (6)

comment:1 Changed 19 months ago by Antoine Martin

Owner: changed from Antoine Martin to psycho_zs

The application name is already forwarded to the platform specific notification API.

Please provide more details as per wiki/ReportingBugs

comment:2 Changed 19 months ago by psycho_zs

Component: serverclient

Debian testing, Xpra 2.1.2, displaying notifications via dunst.

Testing with notify-send -a apptest test test
If run locally, notification is received with:
application: apptest
summary: test
body: test

If run in remote session, notification is received with:
application: Xpra
summary: test
body: test

Notifications from other apps in remote session are also displayed as coming from 'Xpra'.

Test application name is mentioned in client debug log:

2017-09-18 16:34:34,104 _process_notify_show(['notify_show', 'unix:abstract=/tmp/dbus-swCyiCvbB0,guid=67f6a91b10b2c27f09998bb559bf73e3', 9, 'apptest', 0, '', 'test', 'test', -1]) notifier=<xpra.client.notifications.dbus_notifier.DBUS_Notifier object at 0x7f35f27a5490>, server_supports_notifications=True
2017-09-18 16:34:34,106 notification reply: (dbus.UInt32(73L),)

So, problem might be on the client side.

comment:3 Changed 19 months ago by Antoine Martin

Does r16909 fix things?

comment:4 Changed 19 months ago by psycho_zs

Yes, it works!
How about app_name + " (via Xpra)" (or mentioning remote hostname)?

comment:5 Changed 19 months ago by Antoine Martin

Resolution: fixed
Status: newclosed

Try r16910.

ie: you can change the string using

XPRA_NOTIFICATION_APP_NAME="Hello %s (via Xpra" xpra attach ...

We can't use the remote host name because it isn't available to the notification backends at present.

Last edited 19 months ago by Antoine Martin (previous) (diff)

comment:6 Changed 19 months ago by psycho_zs

It works, thanks!

Note: See TracTickets for help on using tickets.