Xpra: Ticket #1676: settings changed on the server should be forwarded to the client

Failure to do so can lead to the client believing that something can be toggled when it cannot. The packets can then trigger (harmless) errors on the server. ie: ticket:1368#comment:6.

Wed, 01 Nov 2017 06:52:06 GMT - Antoine Martin: status, description changed

status changed from new to assigned
description modified (diff)

Mon, 01 Jan 2018 12:34:45 GMT - Antoine Martin: owner, status changed

owner changed from Antoine Martin to J. Max Mena
status changed from assigned to new

Mostly done in r17804. More toggles added in r17806.

Issues not dealt with:

some more settings could now be toggled and forwarded to the client - this will have to do for now
some settings can be toggled, but we don't stop existing operations (cursors are not reset, webcam forwarding does not stop..), this could be added

To test:

connect the client, verify that most features in the system tray menu are enabled
disable a feature on the server and verify that the client's system tray menu reflects that (when disabled, the entry's tooltip often states why it is disabled)

ie:

xpra control :10 toggle-feature bell

As of r17808, for more information on which features can be toggled, see:

xpra control :10 help toggle-feature

Tue, 02 Jan 2018 06:46:46 GMT - Antoine Martin:

Minor related fixes: r17823

Tue, 09 Jan 2018 18:54:29 GMT - J. Max Mena: owner changed

owner changed from J. Max Mena to Antoine Martin

Connecting a trunk r17966 client against a r17823 beta package 2.3 server, I get the following output from the control command when I try to toggle an already disabled clipboard (started with --clipboard=no to simplify things going on):

server returned error code 127
 error processing control command: feature '%s' is set to None!

The '%s' is probably supposed to print Clipboard, right?

Tue, 09 Jan 2018 19:10:24 GMT - J. Max Mena:

Of note, other than that string, it does forward notifications properly.

Wed, 10 Jan 2018 04:37:26 GMT - Antoine Martin: status changed; resolution set

status changed from new to closed
resolution set to fixed

error processing control command: feature '%s' is set to None!

fixed in r17967, error handling improved in r17968, closing.

Sat, 23 Jan 2021 05:30:48 GMT - migration script:

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/1676