xpra icon
Bug tracker and wiki

Opened 5 months ago

Closed 5 months ago

#1695 closed defect (worksforme)

macOS betas do not seem to include the latest code?

Reported by: Ray Donnelly Owned by: Ray Donnelly
Priority: major Milestone: 2.2
Component: platforms Version: trunk
Keywords: macOS Cc: mingw.android@…

Description

I wanted to investigate the jerky trackpad motion and enabled --debug=all on the latest beta:

Xpra --version
xpra v2.2-r17470

In the logs I can see:

wheel view=140336647457344, deltaX=0.000000, deltaY=1.000000, wheel_event_handler=<bound method Delegate.wheel_event_handler of <Delegate: 0x7fa2a738e9d0>>

I then had a look through the code using the blame feature (using this URL: https://www.xpra.org/trac/browser/xpra/trunk/src/xpra/platform/darwin/gdk_bindings.pyx?annotate=blame ) .. there I see:

[16563]	94	            precise = getPreciseScrollingDeltas(nsevent)
        95	            log("wheel view=%i, deltaX=%f, deltaY=%f, precise=%s, wheel_event_handler=%s", <uintptr_t> view, deltaX, deltaY, precise, wheel_event_handler)

So I am wondering why SVN commit has precise=%s in the code while that is missing from the logs in v2.2-r17470.

I guess I am misunderstanding what code goes into the builds here?

Change History (4)

comment:1 Changed 5 months ago by Ray Donnelly

Cc: mingw.android@… added
Component: androidclient
Keywords: question macOS added

comment:2 Changed 5 months ago by Antoine Martin

Component: clientplatforms
Keywords: question removed
Owner: changed from Antoine Martin to Ray Donnelly

You are correct, r16563 is when this code was added and it is still current..
The version you have (v2.2-r17470) should be showing this message!
I have just tried it on my test system with the exact same version and I do see the message:

Xpra --version
xpra v2.2-r17470
Xpra attach tcp://host:port/ -d osx
(..)
wheel view=140389688987952, deltaX=0.000000, deltaY=-4.800293, precise=0, \
    wheel_event_handler=<bound method Delegate.wheel_event_handler of <Delegate: 0x7faf06a1eaf0>>

Maybe you have multiple versions installed and somehow macos is picking up the libraries from the wrong one?
No idea why it would get the version number correctly though.. there have been a number of issues with macos mis-handling multiple copies of the same application installed on the same system.
I would suggest deleting every copy you can find of anything related to xpra, then re-installing this version. And try swapping the DMG for the PKG, or vice versa. I've tried both, and both worked here.

FYI: for debugging this, "-d osx,mouse,pointer" should be enough, "-d all" is a bit much!

comment:3 Changed 5 months ago by Antoine Martin

For reference, here's the original feature ticket: #1157

comment:4 Changed 5 months ago by Ray Donnelly

Resolution: worksforme
Status: newclosed

I don't know how I managed to get it in such a state but after a fresh install it's fine now.

Note: See TracTickets for help on using tickets.