xpra icon
Bug tracker and wiki

Opened 12 days ago

Last modified 18 hours ago

#1735 assigned enhancement

notifications actions

Reported by: Antoine Martin Owned by: Antoine Martin
Priority: major Milestone: 2.3
Component: core Version: 2.2.x
Keywords: Cc:

Description (last modified by Antoine Martin)

Follow up from #1492, adding support for "actions" and "action-icons" optional capabilities.

Would also be nice to manage to:

  • provide our guid with the notifications (the tray does use it)
  • merge the two slightly different implementations of notifyicon ctypes struct
  • tie the notifications to the tray icon belonging to the application which is emitting the notification on win32 (using the appid attribute to identify the tray icon)

Attachments (2)

notifyicon-merge.patch (1.6 KB) - added by Antoine Martin 6 days ago.
switching to the other ctypes implementation does not work: the structures are not equivallent
notifications-actions.patch (15.4 KB) - added by Antoine Martin 23 hours ago.
work in progress

Download all attachments as: .zip

Change History (5)

comment:1 Changed 11 days ago by Antoine Martin

Description: modified (diff)
Status: newassigned

Changed 6 days ago by Antoine Martin

Attachment: notifyicon-merge.patch added

switching to the other ctypes implementation does not work: the structures are not equivallent

comment:2 Changed 6 days ago by Antoine Martin

  • r17997: try to match notifications to the application tray icon - this is unreliable because the notification specification does not have anything in it we can use. Maybe we should submit an optional enhancement?
  • the two different implementations are not equivalent (the size of the struct is different), and things work as they are - so they'll remain separate

Still todo: "actions"

Changed 23 hours ago by Antoine Martin

Attachment: notifications-actions.patch added

work in progress

comment:3 Changed 18 hours ago by Antoine Martin

r18044 adds most of the code required.

Still TODO:

  • hookup the callback events so we can forward them back to the server
  • add "actions" support to the non-dbus implementations (in particular win32 and macos)
  • enable it by default (the actions are not always show on Fedora with gnome shell?)
Note: See TracTickets for help on using tickets.