xpra icon
Bug tracker and wiki

Opened 8 months ago

Closed 8 months ago

#1752 closed defect (fixed)

No module named notifications.common

Reported by: J. Max Mena Owned by: J. Max Mena
Priority: critical Milestone: 2.3
Component: server Version: trunk
Keywords: Cc:

Description

As the title suggests, trunk r18103 breaks servers - making them fail to start with the following traceback:

Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/xpra/scripts/main.py", line 175, in main
    return run_mode(script_file, err, options, args, mode, defaults)
  File "/usr/lib64/python2.7/site-packages/xpra/scripts/main.py", line 1517, in run_mode
    return run_server(error_cb, options, mode, script_file, args, current_display)
  File "/usr/lib64/python2.7/site-packages/xpra/scripts/server.py", line 982, in run_server
    from xpra.x11.server import XpraServer
  File "/usr/lib64/python2.7/site-packages/xpra/x11/server.py", line 55, in <module>
    from xpra.x11.x11_server_base import X11ServerBase
  File "/usr/lib64/python2.7/site-packages/xpra/x11/x11_server_base.py", line 28, in <module>
    from xpra.x11.x11_server_core import X11ServerCore, XTestPointerDevice
  File "/usr/lib64/python2.7/site-packages/xpra/x11/x11_server_core.py", line 45, in <module>
    from xpra.server.gtk_server_base import GTKServerBase
  File "/usr/lib64/python2.7/site-packages/xpra/server/gtk_server_base.py", line 26, in <module>
    from xpra.server.server_base import ServerBase
  File "/usr/lib64/python2.7/site-packages/xpra/server/server_base.py", line 48, in <module>
    from xpra.notifications.common import parse_image_path
ImportError: No module named notifications.common

For reference I'm using a Fedora 26 machine for my server and starting it with xpra start :13 --bind-tcp=0.0.0.0: --start-via=proxy=no --systemd-run=no --start-child=xterm

Change History (5)

comment:1 Changed 8 months ago by Antoine Martin

Owner: changed from Antoine Martin to J. Max Mena
Summary: Trunk r18103 breaks serversNo module named notifications.common
  • I very much doubt that it is r18103 that causes this problem (renamed the ticket), please explain how you came to this conclusion
  • r18110 introduced xpra.notifications.common

r18117 should fix the RPM packaging for it, moving it to python2-xpra and python3-xpra which is common to both clients and servers

comment:2 Changed 8 months ago by J. Max Mena

My bad I read the wrong column on https://xpra.org/trac/changeset/18110/xpra#file13.....which is from r18110. And, rolling my server back to r18102 had it working again since it was before that change.

comment:3 Changed 8 months ago by J. Max Mena

I upped my server to r18117 and it's still failing to start servers with the same error - I'm building from source not using a package

comment:4 Changed 8 months ago by Antoine Martin

I'm building from source not using a package

Using what command line?

Try r18118 or later.

comment:5 Changed 8 months ago by J. Max Mena

Resolution: fixed
Status: newclosed

r18118 fixes it for me.

For reference here is the build command I've been using for a while now:

#clean up build info
rm -f xpra/build_info.py
rm -f xpra/src_info.py

#clean up old build
./setup.py clean

#LDFLAGS=-Wl,-rpath=/usr/lib64/xpra \
#PKG_CONFIG_PATH=$PKG_CONFIG_PATH:/usr/lib64/xpra/pkgconfig \
#    ./setup.py install
#no longer needed
python3 ./setup.py install \
--rpath=/usr/lib64/xpra --pkg-config-path=/usr/lib64/xpra/pkgconfig \
--without-html5 --without-printing
rm -f /usr/bin/xpra
python2 ./setup.py install \
--rpath=/usr/lib64/xpra --pkg-config-path=/usr/lib64/xpra/pkgconfig
Note: See TracTickets for help on using tickets.