#1778 closed task (fixed)
mixins cleanups
Reported by: | Antoine Martin | Owned by: | Antoine Martin |
---|---|---|---|
Priority: | major | Milestone: | 4.0 |
Component: | core | Version: | trunk |
Keywords: | Cc: |
Description (last modified by )
Tasks:
- write more unit tests: #1773, also helpful for:
- identifying leakage of mixin domains: where one mixin relies on another (ie: mmap)
- messy code:
- keyboard, ie:
modifier_client_keycodes
is still too ugly - hello packet code
init_ui
- keyboard, ie:
- r18656 for window server: remove all window packet handlers if window forwarding is disabled
- networkstate: pings require statistics object - move it out into its own domain?
ServerCore.setup()
: weinit_auth
andinit_html_proxy
with options, should be split into a parsing step + setup step (means losing support for the legacypassword-file
- and need another solution forsocket_dir
in sys-auth-base)- more consistent namespace for mixin variables, try to distinguish: settings (command line, env vars), server settings (from hello or update packets), state (focus, buttons, etc)
- some timers can now be tracked and cancelled more easily (ie: ping timers)
Change History (5)
comment:1 Changed 3 years ago by
Description: | modified (diff) |
---|---|
Status: | new → assigned |
Summary: | mixins cleanups and unit tests → mixins cleanups |
comment:2 Changed 22 months ago by
comment:3 Changed 21 months ago by
Milestone: | 3.0 → 4.0 |
---|
Things are in pretty good shape already, see links in comment:2.
See also #2362.
The main dependency issues can be clearly seen by looking at the test code:
- we inject a fake
_protocol
attribute - we inject a fake
_server_sources
dictionary - some other minor attributes (ie:
_upgrading
flag,session_name
,machine_id
, etc..) - some could be duplicated, others
comment:4 Changed 15 months ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
This will do for now, follow up in #2578
comment:5 Changed 3 months ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/1778
Note: See
TracTickets for help on using
tickets.
server mixins: #1838
client mixins: #1861