#1796 closed enhancement (fixed)
modularize client authentication handlers
Reported by: | Antoine Martin | Owned by: | Antoine Martin |
---|---|---|---|
Priority: | major | Milestone: | 3.0 |
Component: | client | Version: | trunk |
Keywords: | Cc: |
Description
The same way this was done for the server modules. The modules can then be configured more easily using the challenge-handlers
string.
Making it easier to test and to implement new ones (ie: "exec" handler which calls an external binary)
We can also define a clearer interface so modules can claim a particular challenge mode, or be used as fallback.
Change History (4)
comment:1 Changed 2 years ago by
Status: | new → assigned |
---|
comment:2 Changed 22 months ago by
At the moment, the process_challenge_uri
comes first and is only used once: we clear the password value after use to give the other authentication handlers a chance to run. (details and examples in ticket:1691#comment:8)
The other handlers behave differently... for some this doesn't matter too much (ie: prompt), but for others this prevents other modules from being tried (ie: file, env, etc)
comment:3 Changed 22 months ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Done in r22711 + r22713 + r22714 + r22715.
All the authentication handlers now live in xpra.client.auth.*
.
Each instance can be configured separately, and the same handler type can be used more than once.
Examples:
- authenticate using "env" module twice:
PASSWORD1=foo PASSWORD2=bar xpra attach tcp://192.168.1.7:10000 -d auth --challenge-handlers=env:name=PASSWORD1 --challenge-handlers=env:name=PASSWORD2
- use a password file (
--password-file
command line argument is deprecated)xpra attach tcp://192.168.1.7:10000 -d auth --challenge-handlers=file,filename=pass.txt
comment:4 Changed 5 weeks ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/1796
See also #1861