Opened 3 weeks ago
Closed 3 weeks ago
#1798 closed enhancement (fixed)
remove synchronization points in nested X11 contexts
Reported by: | Antoine Martin | Owned by: | J. Max Mena |
---|---|---|---|
Priority: | major | Milestone: | 2.3 |
Component: | server | Version: | 2.2.x |
Keywords: | x11 gdk | Cc: |
Description (last modified by )
We have been running with a call to gdk flush whenever we exit a nested X11 context since r1783 (back in 2012!), the unsynced version was briefly enabled in r1777.
r18869 has added unchecked context detection, including a few fixes, so now is a good time to try again.
This may cause crashes if we somehow end up getting back to the gtk main loop without first calling flush and trapping X11 errors. But since those are nested contexts, we should always be exiting the outer context before returning to gtk.
Change History (2)
comment:1 Changed 3 weeks ago by
Description: | modified (diff) |
---|---|
Owner: | changed from Antoine Martin to J. Max Mena |
Note: See
TracTickets for help on using
tickets.
Done in r18922, this tiny commit can be undone by running with
XPRA_SYNCHRONIZE=0 xpra start ..
Effects:
@maxmylyn: mostly a FYI.