xpra icon
Bug tracker and wiki

Changes between Initial Version and Version 1 of Ticket #1798


Ignore:
Timestamp:
03/31/18 15:01:57 (3 years ago)
Author:
Antoine Martin
Comment:

Done in r18922, this tiny commit can be undone by running with XPRA_SYNCHRONIZE=0 xpra start ..

Effects:

  • might make things faster, especially when there is some latency between the xpra server and the X11 server (ie: when running them on separate systems, which is crazy, but I've seen people do that)
  • can make errors get reported against the outer sync context, rather than the innermost one - if and when such errors occur, we can turn sync back on to get better error messages
  • could potentially cause crashes, in which case we'll revert this change - I've stress tested it for 2 weeks and not seen any problems

@maxmylyn: mostly a FYI.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1798

    • Property Owner changed from Antoine Martin to J. Max Mena
  • Ticket #1798 – Description

    initial v1  
    1 We have been running with a call to gdk flush whenever we exit a nested X11 context since r1783, the unsynced version was briefly enabled in r1777.
    2 r18869 added unchecked context detection, including a few fixes, so now is a good time to try again.
     1We have been running with a call to gdk flush whenever we exit a nested X11 context since r1783 (back in 2012!), the unsynced version was briefly enabled in r1777.
     2r18869 has added unchecked context detection, including a few fixes, so now is a good time to try again.
    33This may cause crashes if we somehow end up getting back to the gtk main loop without first calling flush and trapping X11 errors. But since those are nested contexts, we should always be exiting the outer context before returning to gtk.