xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.


Changes between Initial Version and Version 1 of Ticket #1840


Ignore:
Timestamp:
05/13/18 08:00:03 (3 years ago)
Author:
Antoine Martin
Comment:

r19300 disables sliced threads when speed is below XPRA_X264_SLICED_THREADS (which defaults to 60).

@maxmylyn: please use the automated tests to see what impact this has on h264 encoding. In particular, CPU load, latency, bandwidth, etc. Because sliced based threading is so inefficient, you may want to sacrifice a little bit of latency to get better user density.

See also #1851 for vp8 / vp9.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1840

    • Property Owner changed from Antoine Martin to J. Max Mena
  • Ticket #1840 – Description

    initial v1  
    1 Somewhat related
     1Somewhat related to #1839 since we now use vp8 / vp9 more than h264 in the python client.
     2
    23References:
    3 * [https://stackoverflow.com/questions/33624016/ Why sliced thread affect so much on realtime encoding using ffmpeg x264?]: ''frame-based threading has better throughput than slice-based.'',
     4* [https://stackoverflow.com/questions/33624016/ Why sliced thread affect so much on realtime encoding using ffmpeg x264?]: ''frame-based threading has better throughput than slice-based''
    45* [https://github.com/yixia/x264/blob/master/doc/threads.txt x264 doc threads]: ''Each slice adds some bitrate (or equivalently reduces quality) ... Some parts of the encoder are serial, so it doesn't scale well with lots of cpus.''
    5