xpra icon
Bug tracker and wiki

Opened 5 months ago

Closed 5 months ago

Last modified 5 months ago

#1850 closed enhancement (fixed)

tell clients that the video has ended

Reported by: Antoine Martin Owned by: Antoine Martin
Priority: major Milestone: 2.4
Component: encodings Version: 2.3.x
Keywords: Cc:

Description (last modified by Antoine Martin)

At the moment, we keep the decoder context alive until we either discard the window or create a new one, we should be telling the client when it can be discarded.
In some cases, we may already have sent an EOS packet, but what this does is free some of the decoder's internal state, not the decoder itself.

(slightly related to #1836)

Change History (3)

comment:1 Changed 5 months ago by Antoine Martin

Status: newassigned
  • implemented in r19360
  • html5 client support (+python fixup) added in r19361.

Still TODO: add timer to automatically recycle video contexts when window updates stop

Last edited 5 months ago by Antoine Martin (previous) (diff)

comment:2 Changed 5 months ago by Antoine Martin

Description: modified (diff)
Resolution: fixed
Status: assignedclosed

We now timeout the video encoder context after XPRA_VIDEO_TIMEOUT seconds (defaults to 10): r19364 + r19365.

(it's a little bit wasteful to keep re-scheduling this timer for every frame we process but doing anything more clever would increase code complexity)

comment:3 Changed 5 months ago by Antoine Martin

Caused a regression: #1868.

Testing note: the effect of the EOS timer can be seen with:

xpra info | grep -e "window\.[0-9]*\.encoder="
Note: See TracTickets for help on using tickets.