xpra icon
Bug tracker and wiki

Opened 5 months ago

Closed 5 months ago

#1882 closed defect (fixed)

Cannot build with python3

Reported by: أحمد المحمودي Owned by: Antoine Martin
Priority: major Milestone: 2.4
Component: packaging Version: 2.3.x
Keywords: Cc:

Description (last modified by Antoine Martin)

When building xpra 2.3.1 with python3, I got the following build error:

x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -g -O2 -fdebug-prefix-map=/<<BUILDDIR>>/xpra-2.3.1+dfsg=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I/usr/include/python3.6m -c xpra/x11/bindings/core_bindings.c -o build/temp.linux-amd64-3.6/xpra/x11/bindings/core_bindings.o -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -g -fdebug-prefix-map=/build/python3.6-EKG1lX/python3.6-3.6.5=. -specs=/usr/share/dpkg/no-pie-compile.specs -fstack-protector-strong -Wformat -Werror=format-security -Wall -Werror -Wno-error=strict-prototypes -fPIC -g -O2 -fdebug-prefix-map=/<<BUILDDIR>>/xpra-2.3.1+dfsg=. -fstack-protector-strong -Wformat -Werror=format-security
xpra/x11/bindings/core_bindings.c: In function ‘__pyx_pf_4xpra_3x11_8bindings_13core_bindings_16_X11CoreBindings_10get_xatom’:
xpra/x11/bindings/core_bindings.c:3243:188: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
   __pyx_t_1 = ((struct __pyx_vtabstruct_4xpra_3x11_8bindings_13core_bindings__X11CoreBindings *)__pyx_v_self->__pyx_vtab)->xatom(__pyx_v_self, __pyx_v_str_or_int); if (unlikely(__pyx_t_1 == -1L)) __PYX_ERR(0, 131, __pyx_L1_error)
                                                                                                                                                                                            ^
xpra/x11/bindings/core_bindings.c:715:43: note: in definition of macro ‘unlikely’
   #define unlikely(x) __builtin_expect(!!(x), 0)
                                           ^

setup.py was called using the arguments:

python3 setup.py build --with-verbose --with-Xdummy --without-Xdummy_wrapper --without-html5

I didn't have this problem when building xpra 2.1.3 with python3, using the same options.

Full build log can be found at: https://launchpadlibrarian.net/375084690/buildlog_ubuntu-bionic-amd64.xpra_2.3.1+dfsg-2~1.gbp085c5a_BUILDING.txt.gz

Change History (1)

comment:1 Changed 5 months ago by Antoine Martin

Description: modified (diff)
Milestone: 2.4
Resolution: fixed
Status: newclosed

Thanks for the report, this is fixed for 2.3.x in r19679.

Note that the python3 builds are incomplete and cannot be used as servers yet.

Note: See TracTickets for help on using tickets.