Xpra: Ticket #1903: Incorrect icon paths in Window.js

I was told that this issue is already fixed mainstream (https://github.com/totaam/xpra-html5/pull/1#issuecomment-402606387), but I still see '../icons/' instead of just 'icons/' in the Trunk:

	                                '<span id="maximize' + String(wid) + '"><img src="../icons/maximize.png" /></span> '+
	                                '<span id="close' + String(wid) + '"><img src="../icons/close.png" /></span> '+


Thu, 05 Jul 2018 12:14:45 GMT - Antoine Martin: owner changed

Sorry, I misread the patch. We changed to use relative urls to handle non-standard paths. I don't understand why relative paths would not work here. Can you provide a sample configuration?


Thu, 05 Jul 2018 12:14:50 GMT - Antoine Martin: milestone set


Thu, 05 Jul 2018 13:08:37 GMT - berserker:

Replying to Antoine Martin:

We changed to use relative urls to handle non-standard paths. I don't understand why relative paths would not work here. Can you provide a sample configuration?

'icons/close.png' is also a relative path, it does not start with /. I'm trying to run Xpra behind the Jupyter single-user server with its nbserverproxy extension, see https://github.com/jupyterhub/nbserverproxy/issues/35. This is a sample configuration. Probably you are thinking that src paths should be relative to js files location, but it looks like the paths are calculated relative to the path of the page that loaded the js files.


Thu, 05 Jul 2018 13:33:22 GMT - Antoine Martin: status changed; resolution set

Probably you are thinking that src paths should be relative to js files location, but it looks like the paths are calculated relative to the path of the page that loaded the js files.

That's exactly it. Thanks for bearing with me, applied in r19846.


Thu, 05 Jul 2018 22:45:12 GMT - berserker:

Replying to Antoine Martin:

Probably you are thinking that src paths should be relative to js files location, but it looks like the paths are calculated relative to the path of the page that loaded the js files.

That's exactly it. Thanks for bearing with me, applied in r19846.

When it will appear in the Bionic beta repository?


Fri, 06 Jul 2018 01:47:32 GMT - Antoine Martin:

When it will appear in the Bionic beta repository?

Try now.


Sat, 23 Jan 2021 05:36:51 GMT - migration script:

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/1903