xpra icon
Bug tracker and wiki

Opened 3 months ago

Closed 4 weeks ago

#1905 closed defect (fixed)

macos url handler does not open

Reported by: Antoine Martin Owned by: Antoine Martin
Priority: major Milestone: 2.4
Component: platforms Version: 2.3.x
Keywords: Cc:

Description (last modified by Antoine Martin)

Tested as part of #1894.
Running:

open xpra+tcp://192.168.1.7:10000/

Fires up xpra as expected, but it actually does not connect anywhere.

The URL handling code was originally added in r12380.

Change History (3)

comment:1 Changed 4 weeks ago by Antoine Martin

Description: modified (diff)
Status: newassigned

comment:2 Changed 4 weeks ago by Antoine Martin

This does work (as expected - only trimming the connection string):

/Applications/Xpra.app/Contents/MacOS/Xpra attach xpra+tcp://HOST:PORT/

This does fire up the launcher:

open -a Xpra.app

And these fire up the launcher with the URL string (though there are parsing problems?):

open -a Xpra.app xpra+tcp://HOST+PORT/
open -a Xpra.app xpra://HOST+PORT/

So does this:

open xpra://HOST+PORT/

Maybe macos needs a reboot or something, because previously the same open command wouldn't get to the point of showing the launcher..

comment:3 Changed 4 weeks ago by Antoine Martin

Resolution: fixed
Status: assignedclosed

Fixes in:

  • r20154: look for the transport mode in the scheme part of the url
  • r20155: simplify url parsing
  • r20156 + r20157: add missing transport options, fix url parsing code

Going through the launcher for handling URLs has one advantage: we have a GUI for showing connection errors and URL problems, but there is also a problem with it: the global menu shown is the one for the launcher, not the full one - as per #1385.

Note: See TracTickets for help on using tickets.