xpra icon
Bug tracker and wiki

Opened 3 months ago

Closed 3 months ago

Last modified 2 months ago

#1929 closed defect (fixed)

python-lz4 2.1 is broken, again

Reported by: totaamwin32 Owned by: Antoine Martin
Priority: blocker Milestone: 2.4
Component: packaging Version: 2.3.x
Keywords: Cc:

Description

on win32 clean install:

Traceback (most recent call last):
  File "E:\Xpra\trunk\src\dist/lib/xpra/net/compression.py", line 24, in <module>
    import lz4
  File "C:/msys64/mingw64/lib/python2.7/site-packages/lz4-2.1.0-py2.7-mingw.egg/lz4/__init__.py", line 8, in <module>
    VERSION = __version__
NameError: name '__version__' is not defined

Change History (2)

comment:1 Changed 3 months ago by totaamwin32

Resolution: fixed
Status: newclosed

So, it turns out (unsurprisingly) that python-lz4 has changed how it gets its version information yet again - I can't remember if it's 3rd or 4th time now. And when it doesn't get its version number, the whole library fails to load!

For such a small and simple wrapper library, the number of releases and constant needless breakage is shocking.

Here's what it does now:

from pkg_resources import get_distribution, DistributionNotFound
try:
    __version__ = get_distribution(__name__).version
except DistributionNotFound:
    # package is not installed
    pass

And here's what I replaced it with to get on with more productive things:

    # package is not installed
    __version__ = "2.1.0"

Let's try to deal with this in #1883 so this won't break again next time there is an update.

comment:2 Changed 2 months ago by Antoine Martin

r20171 fixes the packaging for macos by adding the patch to jhbuild.

Note: See TracTickets for help on using tickets.