xpra icon
Bug tracker and wiki

Opened 3 weeks ago

Closed 3 weeks ago

#1944 closed enhancement (fixed)

parsing the command line is too expensive

Reported by: Antoine Martin Owned by: J. Max Mena
Priority: major Milestone: 2.4
Component: core Version: 2.3.x
Keywords: Cc:

Description

The audio subprocess ends up loading picture and video codecs, initializing dozens of loggers, etc.

This was already improved slightly:

Change History (2)

comment:1 Changed 3 weeks ago by Antoine Martin

Owner: changed from Antoine Martin to J. Max Mena

Done for video encoders in r20269 + r20270.
We now launch all sound subprocesses with the extra arguments:

'--windows=no', \
'--video-encoders=none', '--csc-modules=none', \
'--video-decoders=none', '--proxy-video-encoders=none'

This avoids loading the "video helper" class, which would load the video and csc codecs.
The list of arguments can be overriden with XPRA_DEFAULT_SOUND_COMMAND_ARGS.

One area where we could still do better is packet encoding and compression: we load all of them (ie: lz4, lzo and zlib - rencode, bencode and yaml) whether we use them or not. Not a big problem since those are all quite small.

@maxmylyn: just a FYI. The audio subprocess should start a bit faster (barely measurable in most cases) and use less memory.

Last edited 3 weeks ago by Antoine Martin (previous) (diff)

comment:2 Changed 3 weeks ago by J. Max Mena

Resolution: fixed
Status: newclosed

Noted and closing.

Note: See TracTickets for help on using tickets.