xpra icon
Bug tracker and wiki

Opened 6 weeks ago

Closed 6 weeks ago

#1973 closed enhancement (fixed)

IE11 Support

Reported by: mjharkin Owned by: mjharkin
Priority: minor Milestone: 2.4
Component: html5 Version: trunk
Keywords: Cc:

Description (last modified by Antoine Martin)

@Antoine Looks like I'm a little late on this as I think you've covered most of this in r20580 but maybe missing:

Fullscreen request:Added IE11 fullscreen request

startsWith and includes Polyfills
My approach was to add a seperate polyfill script so it's easier to remove when IE finally dies. For reference added IE11 compatability

Change History (7)

comment:1 Changed 6 weeks ago by Antoine Martin

Description: modified (diff)
Owner: changed from Antoine Martin to mjharkin

Merged in r20583 + r20584, thanks.

Can you please specify what copyright applies to those polyfills? (should be the same as ECMA6 I guess - looks like a BSD variant?)

Last edited 6 weeks ago by Antoine Martin (previous) (diff)

comment:2 Changed 6 weeks ago by mjharkin

Sorry, started here https://github.com/paulmillr/es6-shim (MIT) but it was overkill for a few polyfills so ended up just grabbing them from elsewhere, I've already give myself a slap on the wrists!

Just tested r20584 but I think:

window.console = window.console || {
	  log: function () {}
};
	

needs to be in index.html otherwise Developer tools needs to be open.

comment:3 Changed 6 weeks ago by Antoine Martin

needs to be in index.html otherwise Developer tools needs to be open.

No idea where that needs to go, I've tried a few obvious places and none helped.
(and since having the developer console open "fixes" things, catch 22)

comment:4 Changed 6 weeks ago by mjharkin

Sorry my mistake I should have tidied up before submitting the change:

What's missing is actually (1st diff from https://github.com/mjharkin/Xpra/commit/5904fe329d9b1f11acffd65435ddd49ed2406f32 )
This could equally be added to es6-shim.js instead of index.html, depends on your preference.

var console = console || { log: function(){} };

The following should be removed from es6-shim.js

window.console = window.console || {
	  log: function () {}
};

comment:5 Changed 6 weeks ago by Antoine Martin

Thanks, applied in r20592.

Can we close this ticket?

comment:6 Changed 6 weeks ago by mjharkin

r20592 changes in index.html and connect.html can be removed.
Otherwise this is good to close.

Thanks.

comment:7 Changed 6 weeks ago by Antoine Martin

Resolution: fixed
Status: newclosed

Good catch, done in r20593.

Note: See TracTickets for help on using tickets.