xpra icon
Bug tracker and wiki

Opened 5 months ago

Closed 5 months ago

#2082 closed defect (fixed)

fix for r21210 which breaks nvenc

Reported by: Nathan Hallquist Owned by: Antoine Martin
Priority: critical Milestone: 2.5
Component: encodings Version: 2.4.x
Keywords: Cc:

Description (last modified by Antoine Martin)

A "for" loop was eliminated in r21210 but a "break" was left behind. This extra break breaks the wrong for loop.

rumba:~/src # svn diff --patch-compatible xpra/codecs/video_helper.py
Index: xpra/codecs/video_helper.py
===================================================================
--- xpra/codecs/video_helper.py (revision 21228)
+++ xpra/codecs/video_helper.py (working copy)
@@ -43,7 +43,6 @@
         module_name = CODEC_TO_MODULE[codec_name]
         if has_codec_module(module_name):
             names.append(codec_name)
-            break
     return names

 #all the codecs we know about:

Change History (2)

comment:1 Changed 5 months ago by Nathan Hallquist

Component: androidencodings
Priority: majorcritical

Forgot to mark the patch as code, and don't have permission to edit my original post.

Index: xpra/codecs/video_helper.py
===================================================================
--- xpra/codecs/video_helper.py (revision 21228)
+++ xpra/codecs/video_helper.py (working copy)
@@ -43,7 +43,6 @@
         module_name = CODEC_TO_MODULE[codec_name]
         if has_codec_module(module_name):
             names.append(codec_name)
-            break
     return names

 #all the codecs we know about:

comment:2 Changed 5 months ago by Antoine Martin

Description: modified (diff)
Resolution: fixed
Status: newclosed

Oops, sorry about that. Applied in r21229.

Note: See TracTickets for help on using tickets.