Opened 2 years ago
Closed 2 years ago
#2082 closed defect (fixed)
fix for r21210 which breaks nvenc
| Reported by: | Nathan Hallquist | Owned by: | Antoine Martin |
|---|---|---|---|
| Priority: | critical | Milestone: | 2.5 |
| Component: | encodings | Version: | 2.4.x |
| Keywords: | Cc: |
Description (last modified by )
A "for" loop was eliminated in r21210 but a "break" was left behind. This extra break breaks the wrong for loop.
rumba:~/src # svn diff --patch-compatible xpra/codecs/video_helper.py
Index: xpra/codecs/video_helper.py
===================================================================
--- xpra/codecs/video_helper.py (revision 21228)
+++ xpra/codecs/video_helper.py (working copy)
@@ -43,7 +43,6 @@
module_name = CODEC_TO_MODULE[codec_name]
if has_codec_module(module_name):
names.append(codec_name)
- break
return names
#all the codecs we know about:
Change History (2)
comment:1 Changed 2 years ago by
| Component: | android → encodings |
|---|---|
| Priority: | major → critical |
comment:2 Changed 2 years ago by
| Description: | modified (diff) |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Oops, sorry about that. Applied in r21229.
Note: See
TracTickets for help on using
tickets.
copyleft 2010 - 2020
Forgot to mark the patch as code, and don't have permission to edit my original post.
Index: xpra/codecs/video_helper.py =================================================================== --- xpra/codecs/video_helper.py (revision 21228) +++ xpra/codecs/video_helper.py (working copy) @@ -43,7 +43,6 @@ module_name = CODEC_TO_MODULE[codec_name] if has_codec_module(module_name): names.append(codec_name) - break return names #all the codecs we know about: