xpra icon
Bug tracker and wiki

Opened 5 months ago

Closed 4 months ago

#2086 closed enhancement (fixed)

window property for setting the encodings to use

Reported by: Nathan Hallquist Owned by: Nathan Hallquist
Priority: major Milestone: 2.5
Component: encodings Version: 2.4.x
Keywords: Cc:

Description

One of my users pointed out to me that "tkdiff" is nearly impossible to use unless the "raw" encoding is forced from the tray.

I can confirm that scrolling in "tkdiff" is terrible without that. The entire text pane becomes a blob of random-ish color. It looks great with "RAW" encoding.

My user still wants to be able to get video encoding in his CAD windows while using "tkdiff" (hence the feature request).

I have experimented with setting window quality to 99 and various speed settings but to no avail. I've also tried to disable scroll encoding and that made no difference either.

Change History (5)

comment:1 Changed 5 months ago by Antoine Martin

Status: newassigned
Summary: xprop for restricting a window to RAW encodingwindow property for setting the encodings to use

One of my users pointed out to me that "tkdiff" is nearly impossible to use unless the "raw" encoding is forced from the tray.

Don't use the "raw" encoding unless you have heaps of bandwidth to spare.
Setting a high quality + high speed should have the same effect, but without using up all the bandwidth.

Some of the content-type related fixes from ticket:2023#comment:9 definitely help here: we now correctly tag tkdiff as "text" content-type, and boost the quality for text more.

But the real problem comes from the x264 codec, switching to vpx (ie: --video-encoders=vpx) fixes the issue for me.

I am moving this to a new ticket: #2087. (it includes a screenshot showing the problem)

I have experimented with setting window quality to 99 and various speed settings but to no avail. I've also tried to disable scroll encoding and that made no difference either.

This will probably go away once the x264 bug above is fixed.

I have updated the ticket description with a more generic solution we could still implement at some point.

comment:2 Changed 5 months ago by Antoine Martin

The x264 regression has been fixed: ticket:2087#comment:4

comment:3 Changed 4 months ago by Antoine Martin

Owner: changed from Antoine Martin to Nathan Hallquist
Status: assignednew

Implemented in r21400.

$ xpra info | egrep "encoding-hint|encoding.selection"
client.window.1.encoding.selection=best_encoding_video
client.window.1.property.encoding-hint=

Then after changing the window property using:

xprop -f _XPRA_ENCODING 8s -set _XPRA_ENCODING webp 

The server's -d metadata log shows:

2019-01-19 19:53:20,701 Property changed on 0xc00022: _XPRA_ENCODING
2019-01-19 19:53:20,701 encoding=webp
2019-01-19 19:53:20,701 updateprop(encoding, webp) unchanged

And then we can verify that the encoding is used with:

$ xpra info | egrep "encoding-hint|encoding.selection"
client.window.1.encoding.selection=encoding_is_hint
client.window.1.property.encoding-hint=webp

@nathan_lstc: please close if that works for you.

comment:4 Changed 4 months ago by Nathan Hallquist

Thanks!

comment:5 Changed 4 months ago by Nathan Hallquist

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.