xpra icon
Bug tracker and wiki

Opened 3 months ago

Closed 3 months ago

#2087 closed defect (fixed)

x264 quality regression

Reported by: Antoine Martin Owned by: Antoine Martin
Priority: critical Milestone: 2.5
Component: encodings Version: 2.4.x
Keywords: Cc:

Description (last modified by Antoine Martin)

Discovered as part of #2086, the picture is really messed up despite the high quality setting.

This is what it looks like:
tkdiff very degraded

The changelog is here: log/xpra/trunk/src/xpra/codecs/enc_x264.
What stands out:

  • r21114 threading
  • r20519 preset
  • r20399 bandwidth limit
  • r20392 "grain" tuning for text content - probably not the one (manually reverted to test)

Attachments (1)

tkdiff.png​ (234.5 KB) - added by Antoine Martin 3 months ago.
tkdiff very degraded

Download all attachments as: .zip

Change History (5)

Changed 3 months ago by Antoine Martin

Attachment: tkdiff.png​ added

tkdiff very degraded

comment:1 Changed 3 months ago by Antoine Martin

Description: modified (diff)
Status: new → assigned

comment:2 Changed 3 months ago by Nathan Hallquist

I have updated and deployed to this user. He reports that with --video-encoders=vpx,nvenc things are much better.

Thank you.

Last edited 3 months ago by Nathan Hallquist (previous) (diff)

comment:3 Changed 3 months ago by Antoine Martin

Priority: major → critical

So the problem comes from bandwidth-limit integration (r20399)

comment:4 Changed 3 months ago by Antoine Martin

Resolution: → fixed
Status: assigned → closed

Fixed in r21249. (was some left-over test code)

Note: See TracTickets for help on using tickets.