xpra icon
Bug tracker and wiki

#2100 closed enhancement (fixed)

add a novideo content-type

Reported by: Nathan Hallquist Owned by: Nathan Hallquist
Priority: major Milestone: 2.5
Component: encodings Version: 2.4.x
Keywords: Cc:

Description

Some of my users really dislike video frames in xterm. With this patch, users can (1) set a novideo content type and (2) set a guesser rule from an environment variable (from a systemd entry I have):

Environment=XPRA_CONTENT_TYPE_DEFS=class-instance:xterm=novideo

Attachments (1)

novideo-content-type.patch (4.8 KB) - added by Nathan Hallquist 10 months ago.

Download all attachments as: .zip

Change History (6)

Changed 10 months ago by Nathan Hallquist

Attachment: novideo-content-type.patch added

comment:1 Changed 10 months ago by Antoine Martin

Owner: changed from Antoine Martin to Nathan Hallquist

I like the idea.

We could just add a new flag like TEXT_NOVIDEO. This would apply to all applications that are meant to be text.

This does not use lossless:

            return nonvideo(info="lossless content-type")

It will use a non-video encoding, usually at a high quality setting, but not lossless unless you change the quality value with this call.
And if you do, then you might as well call the new content-type "lossless"?

comment:2 Changed 10 months ago by Nathan Hallquist

I had originally gone with lossless and then changed my mind after trying nonvideo and finding myself happy with that. I forgot to change the text is all.

I am okay with either choice. I defer to you.

comment:3 Changed 10 months ago by Nathan Hallquist

Component: androidencodings
Type: defectenhancement

comment:4 Changed 10 months ago by Antoine Martin

The part adding an env var for specifying content type definitions was merged in r21302 (see ticket:1950#comment:8).
r21303 disables video encoders for windows with the "text" content-type hint.

@nathan_lstc: does this work OK for you? if so, please close.

Last edited 10 months ago by Antoine Martin (previous) (diff)

comment:5 Changed 10 months ago by Nathan Hallquist

Resolution: fixed
Status: newclosed

This is great! Thank you.

Note: See TracTickets for help on using tickets.