xpra icon
Bug tracker and wiki

Opened 5 months ago

Closed 5 months ago

#2253 closed defect (fixed)

Frames on Frameless windows

Reported by: Mark Harkin Owned by: Mark Harkin
Priority: major Milestone: 3.0
Component: server Version: 2.5.x
Keywords: Cc:

Description

Looks like a recent server side change has caused frameless windows to appear with a frame (tested on r22133).

I've at least 2 java splash screens (Eclipse and SQL Developer) displaying on the client with frames. Haven't been able to confirm if it's specific to java.

Can provide more details if needed.

Attachments (1)

spashscreen.patch (499 bytes) - added by Antoine Martin 5 months ago.
don't decorate SPLASH window types

Download all attachments as: .zip

Change History (7)

comment:1 Changed 5 months ago by Antoine Martin

Owner: changed from Antoine Martin to Mark Harkin

Can you post the -d metadata client output?

comment:2 Changed 5 months ago by Mark Harkin

Sure, from the client log:

2019-04-04 14:20:54,704 process_new_common: [2, 734, 374, 452, 302, {'size-constraints': {'position': (0, 0), 'base-size': (0, 0), 'gravity': 1, 'minimum-size': (452, 302)}, 'xid': '0xc00002', 'title': 'Eclipse', 'icon-title': 'Eclipse', 'client-machine': 'cef286b6eef3', 'pid': 236, 'group-leader-xid': 12582913, 'window-type': ('SPLASH',), 'class-instance': ('java', 'Java'), 'set-initial-position': True}], metadata={'size-constraints': {'position': (0, 0), 'base-size': (0, 0), 'gravity': 1, 'minimum-size': (452, 302)}, 'xid': '0xc00002', 'title': 'Eclipse', 'pid': 236, 'client-machine': 'cef286b6eef3', 'icon-title': 'Eclipse', 'group-leader-xid': 12582913, 'window-type': ('SPLASH',), 'class-instance': ('java', 'Java'), 'set-initial-position': True}, OR=False
2019-04-04 14:20:54,725 popup_types(['SPLASH'])=()
2019-04-04 14:20:54,735 set_alpha() has_alpha=False, <class 'xpra.client.gl.gtk_base.gl_drawing_area.GLDrawingArea'>.HAS_ALPHA=False, realized=False
2019-04-04 14:20:54,740 update_metadata({'size-constraints': {'position': (0, 0), 'base-size': (0, 0), 'gravity': 1, 'minimum-size': (452, 302)}, 'xid': '0xc00002', 'title': 'Eclipse', 'pid': 236, 'client-machine': 'cef286b6eef3', 'icon-title': 'Eclipse', 'group-leader-xid': 12582913, 'window-type': ('SPLASH',), 'class-instance': ('java', 'Java'), 'set-initial-position': True})
2019-04-04 14:20:54,743 set_metadata({'size-constraints': {'position': (0, 0), 'base-size': (0, 0), 'gravity': 1, 'minimum-size': (452, 302)}, 'xid': '0xc00002', 'title': 'Eclipse', 'pid': 236, 'client-machine': 'cef286b6eef3', 'icon-title': 'Eclipse', 'group-leader-xid': 12582913, 'window-type': ('SPLASH',), 'class-instance': ('java', 'Java'), 'set-initial-position': True})
2019-04-04 14:20:57,334 metadata update for window 2: {'title': 'Eclipse IDE '}
2019-04-04 14:20:57,346 update_metadata({'title': 'Eclipse IDE '})
2019-04-04 14:20:57,350 set_metadata({'title': 'Eclipse IDE '})
2019-04-04 14:20:57,358 metadata update for window 2: {'icon-title': 'Eclipse IDE '}
2019-04-04 14:20:57,364 update_metadata({'icon-title': 'Eclipse IDE '})
2019-04-04 14:20:57,378 set_metadata({'icon-title': 'Eclipse IDE '})

Not seeing the issue in the HTML client, so I guess I might have to update the client. I'll test that out shortly.

comment:3 Changed 5 months ago by Antoine Martin

That's odd, this code has not changed much at all recently.

Can you try the patch attached? (this is a client-side fix)

Changed 5 months ago by Antoine Martin

Attachment: spashscreen.patch added

don't decorate SPLASH window types

comment:4 in reply to:  3 Changed 5 months ago by Mark Harkin

Replying to Antoine Martin:

That's odd, this code has not changed much at all recently.

Can you try the patch attached? (this is a client-side fix)

Updating the client and applying the patch didn't help.

Not sure if it's this issue but had a quick look at how the metadata looked before this became an issue and looks like 'decorations': 0 was being sent but isn't in the latest version. (Sorry for the bad wrapping).

2019-04-04 16:04:27,526 process_new_common: [208, 1694, 449, 452, 302, {'size-co
nstraints': {'position': (0, 0), 'base-size': (0, 0), 'gravity': 1, 'minimum-siz
e': (452, 302)}, 'xid': '0x1e00003', 'title': 'Eclipse', 'pid': 10692, 'client-m
achine': 'afa355779adf', 'icon-title': 'Eclipse', 'group-leader-xid': 31457281,
'window-type': ('SPLASH',), 'decorations': 0, 'class-instance': ('java', 'Java')
, 'set-initial-position': True}], metadata={'size-constraints': {'position': (0,
 0), 'base-size': (0, 0), 'gravity': 1, 'minimum-size': (452, 302)}, 'xid': '0x1
e00003', 'title': 'Eclipse', 'icon-title': 'Eclipse', 'client-machine': 'afa3557
79adf', 'pid': 10692, 'group-leader-xid': 31457281, 'window-type': ('SPLASH',),
'decorations': 0, 'class-instance': ('java', 'Java'), 'set-initial-position': Tr
ue}, OR=False
2019-04-04 16:04:27,530 popup_types(['SPLASH'])=()
2019-04-04 16:04:27,531 set_alpha() has_alpha=False, <class 'xpra.client.gtk2.pi
xmap_backing.PixmapBacking'>.HAS_ALPHA=False, realized=False
2019-04-04 16:04:27,533 update_metadata({'size-constraints': {'position': (0, 0)
, 'base-size': (0, 0), 'gravity': 1, 'minimum-size': (452, 302)}, 'xid': '0x1e00
003', 'title': 'Eclipse', 'icon-title': 'Eclipse', 'client-machine': 'afa355779a
df', 'pid': 10692, 'group-leader-xid': 31457281, 'window-type': ('SPLASH',), 'de
corations': 0, 'class-instance': ('java', 'Java'), 'set-initial-position': True}
)

comment:5 Changed 5 months ago by Antoine Martin

Are you running trunk?
r22318 fixes a hint parsing bug.
The eclipse splash screen looks ok for me now.

comment:6 in reply to:  5 Changed 5 months ago by Mark Harkin

Resolution: fixed
Status: newclosed

Replying to Antoine Martin:

Are you running trunk?
r22318 fixes a hint parsing bug.
The eclipse splash screen looks ok for me now.

Yes, running on trunk.

r22318 fixed it, thanks.

Note: See TracTickets for help on using tickets.