Python3 tray start menu broken

[Mark Harkin]

Windows Python3 client r23522 (latest from beta repo)

Tray start menu commands don't launch for some applications.
Client side error:

Traceback (most recent call last):
  File "E:\Xpra\trunk\src/xpra/client/gtk_base/gtk_tray_menu_base.py", line 1668, in app_launch
  File "C:/msys64/mingw64/lib/python3.7/re.py", line 192, in sub
    return _compile(pattern, flags).sub(repl, string, count)

[Antoine Martin]

Do you have the full backtrace?
What was the exception type?

Does r23602 fix things?

[Mark Harkin]

Replying to Antoine Martin:

Do you have the full backtrace?

Sorry bad copy and paste

Traceback (most recent call last):
  File "E:\Xpra\trunk\src/xpra/client/gtk_base/gtk_tray_menu_base.py", line 1668, in app_launch
  File "C:/msys64/mingw64/lib/python3.7/re.py", line 192, in sub
    return _compile(pattern, flags).sub(repl, string, count)
TypeError: sequence item 1: expected a bytes-like object, str found

Does r23602 fix things?

I can test if you can upload a new beta, haven't build the windows client in quite some time.

[Antoine Martin]

I can test if you can upload a new beta, haven't build the windows client in quite some time.

Done: https://xpra.org/beta/windows.
Based on the stack trace, I'm fairly confident that the fix is correct.

[Mark Harkin]

Yep, works for me. Thanks.

[migration script]

this ticket has been moved to: ​https://github.com/Xpra-org/xpra/issues/2395