xpra icon
Bug tracker and wiki

Opened 3 weeks ago

Closed 3 weeks ago

#2402 closed defect (fixed)

packet aliases are not used

Reported by: Antoine Martin Owned by: Antoine Martin
Priority: major Milestone: 3.0
Component: client Version: 3.0.x
Keywords: Cc:

Description

That's the case since the split into mixins: we initialize the packet handlers later and so the hello packet does not have the aliases initialized...

Backtraces:

  • hello packet:
      File "/usr/bin/xpra", line 26, in <module>
        sys.exit(main(sys.argv[0], sys.argv))
      File "/usr/lib64/python3.7/site-packages/xpra/scripts/main.py", line 110, in main
        return run_mode(script_file, err, options, args, mode, defaults)
      File "/usr/lib64/python3.7/site-packages/xpra/scripts/main.py", line 452, in run_mode
        return run_client(error_cb, options, args, mode)
      File "/usr/lib64/python3.7/site-packages/xpra/scripts/main.py", line 1455, in run_client
        return do_run_client(app)
      File "/usr/lib64/python3.7/site-packages/xpra/scripts/main.py", line 1688, in do_run_client
        return app.run()
      File "/usr/lib64/python3.7/site-packages/xpra/client/gtk_base/gtk_client_base.py", line 144, in run
        self.gtk_main()
      File "/usr/lib64/python3.7/site-packages/xpra/client/gtk_base/gtk_client_base.py", line 150, in gtk_main
        gtk_main()
      File "/usr/lib64/python3.7/site-packages/gi/overrides/Gtk.py", line 1630, in main
        return _Gtk_main(*args, **kwargs)
      File "/usr/lib64/python3.7/site-packages/xpra/client/client_base.py", line 614, in _process_challenge
        r = handler.handle(packet)
      File "/usr/lib64/python3.7/site-packages/xpra/client/auth/uri_handler.py", line 21, in handle
        self.client.send_challenge_reply(packet, self.client.password)
      File "/usr/lib64/python3.7/site-packages/xpra/client/client_base.py", line 739, in send_challenge_reply
        self.do_send_challenge_reply(challenge_response, client_salt)
      File "/usr/lib64/python3.7/site-packages/xpra/client/client_base.py", line 743, in do_send_challenge_reply
        self.send_hello(challenge_response, client_salt)
      File "/usr/lib64/python3.7/site-packages/xpra/client/client_base.py", line 340, in send_hello
        hello.update(self.make_hello())
      File "/usr/lib64/python3.7/site-packages/xpra/client/gtk_base/gtk_client_base.py", line 664, in make_hello
        capabilities = UIXpraClient.make_hello(self)
      File "/usr/lib64/python3.7/site-packages/xpra/client/ui_client_base.py", line 338, in make_hello
        caps = XpraClientBase.make_hello(self)
      File "/usr/lib64/python3.7/site-packages/xpra/client/client_base.py", line 430, in make_hello
        traceback.print_stack()
    
  • aliases initialization:
      File "/usr/lib64/python3.7/threading.py", line 890, in _bootstrap
        self._bootstrap_inner()
      File "/usr/lib64/python3.7/threading.py", line 926, in _bootstrap_inner
        self.run()
      File "/usr/lib64/python3.7/threading.py", line 870, in run
        self._target(*self._args, **self._kwargs)
      File "/usr/lib64/python3.7/site-packages/xpra/net/protocol.py", line 802, in _read_parse_thread_loop
        self.do_read_parse_thread_loop()
      File "/usr/lib64/python3.7/site-packages/xpra/net/protocol.py", line 1027, in do_read_parse_thread_loop
        self._process_packet_cb(self, packet)
      File "/usr/lib64/python3.7/site-packages/xpra/client/ui_client_base.py", line 734, in process_packet
        XpraClientBase.process_packet(self, proto, packet)
      File "/usr/lib64/python3.7/site-packages/xpra/client/client_base.py", line 951, in process_packet
        handler(packet)
      File "/usr/lib64/python3.7/site-packages/xpra/client/client_base.py", line 799, in _process_hello
        if not self.server_connection_established():
      File "/usr/lib64/python3.7/site-packages/xpra/client/ui_client_base.py", line 378, in server_connection_established
        if not XpraClientBase.server_connection_established(self):
      File "/usr/lib64/python3.7/site-packages/xpra/client/client_base.py", line 828, in server_connection_established
        self.init_aliases()
      File "/usr/lib64/python3.7/site-packages/xpra/client/client_base.py", line 319, in init_aliases
        traceback.print_stack()
    

Change History (1)

comment:1 Changed 3 weeks ago by Antoine Martin

Resolution: fixed
Status: newclosed

Fixed in r23711. (too difficult to backport)

Note: See TracTickets for help on using tickets.