#2533 closed defect (fixed)
xpra upgrade subcommand regression
Reported by: | Antoine Martin | Owned by: | Antoine Martin |
---|---|---|---|
Priority: | major | Milestone: | 4.0 |
Component: | server | Version: | 3.0.x |
Keywords: | Cc: | stdedos@… |
Description
As reported in ticket:2524#comment:3.
Easily reproducible, also affects version 3 with both python2 and python3.
Odd because I'm pretty sure I had tested this when I added the "upgrade-desktop" and "upgrade-shadow" subcommands.
Change History (7)
comment:1 Changed 16 months ago by
Cc: | stdedos@… added |
---|
comment:2 Changed 16 months ago by
Cc: | stdedos@… removed |
---|---|
Status: | new → assigned |
comment:3 Changed 16 months ago by
Cc: | stdedos@… added |
---|
Isn't CC how you watch a ticket in Trac?
I hope it's okay to track when this is fixed - especially since it seems it will be a bit long time. :/
comment:4 Changed 16 months ago by
Starting from r20757 and reverting the changes to selection.py
fixes the problem.
Narrowing it further points to this specific change:
self.clipboard.set_with_data([("VERSION", 0, 0)], self._get, self._clear, None)
changed to:
set_clipboard_data(self.clipboard, "VERSION")
That's because although the documentation does refer to it, set_with_data
is no longer exposed with GTK3: gtk_clipboard_set_with_data/set_with_owner is binding-unfriendly.
So we need to change two things:
- set the version using something equivalent to:
outdata.set("INTEGER", 32, pack("@ii", 2, 0))
- catch the selection clear event and emit
selection-lost
comment:5 Changed 16 months ago by
comment:6 Changed 16 months ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:7 Changed 3 months ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/2533
Bisecting:
So the problem is r20757 and it's a big changeset...