xpra upgrade subcommand regression

[Antoine Martin]

As reported in ticket:2524#comment:3.

Easily reproducible, also affects version 3 with both python2 and python3.
Odd because I'm pretty sure I had tested this when I added the "upgrade-desktop" and "upgrade-shadow" subcommands.

[Antoine Martin]

Bisecting:

• 3.0 bad
• 1.0.x OK (also OK with trunk python3 clients - so the bug is "server" side)
• 2.5.x bad
• 2.0.x OK
• 2.2.x OK
• 2.4.x OK
• 2.5.0 r22138 bad
• 2.4.0 r20681 OK
• r21400 bad
• r21000 bad
• r20800 bad
• r20700 OK
• r20750 OK
• r20775 bad
• r20762 bad
• r20756 OK
• r20759 bad
• r20757 bad

So the problem is r20757 and it's a big changeset...

[stdedos]

Isn't CC how you watch a ticket in Trac?

I hope it's okay to track when this is fixed - especially since it seems it will be a bit long time. :/

[Antoine Martin]

Starting from r20757 and reverting the changes to selection.py fixes the problem.
Narrowing it further points to this specific change:

self.clipboard.set_with_data([("VERSION", 0, 0)],
	                                     self._get,
	                                     self._clear,
	                                     None)

changed to:

set_clipboard_data(self.clipboard, "VERSION")

That's because although the documentation does refer to it, set_with_data is no longer exposed with GTK3: ​gtk_clipboard_set_with_data/set_with_owner is binding-unfriendly.

So we need to change two things:

• set the version using something equivalent to:

  outdata.set("INTEGER", 32, pack("@ii", 2, 0))
  

• catch the selection clear event and emit selection-lost

[Antoine Martin]

Working fix in r24834 + r24835.

Still TODO:

• find a way to use the correct format for setting the VERSION - GTK3 lacks the feature which GTK2 has always had
• add a timeout when trying to upgrade
• backports

[Antoine Martin]

Updates:

• VERSION fix moved to #2535 - things work without, but we should be spec compliant (GTK2 was...)
• r24837 adds a timeout, we now exit and return exit_codes.TIMEOUT if the current owner does not give up the selection
• r24838 cleanup + docstring
• r24839 backports

[migration script]

this ticket has been moved to: ​https://github.com/Xpra-org/xpra/issues/2533