xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.

Opened 2 years ago

Last modified 17 months ago

#2556 assigned enhancement

rate limit xdg-menu packets

Reported by: Antoine Martin Owned by: Antoine Martin
Priority: critical Milestone: 4.2
Component: core Version: 3.0.x
Keywords: Cc:

Description (last modified by Antoine Martin)

This packet sent at the start is getting close to 1MB, mostly because of all the icon data we send with each menu entry.

To fix:

  • add a new setting_change_attribute capability to clients
  • add an extra flag to the setting-change packet sent by send_setting_change so we can replace-or-update (0=replace)
  • send xdg-menu data one key at a time (one menu at a time), using 1=update
  • optional: extra marker flag for "end of updates"? (so the client knows it is a good time to update its UI)

Change History (5)

comment:1 Changed 2 years ago by Antoine Martin

Description: modified (diff)
Status: newassigned

comment:2 Changed 2 years ago by Antoine Martin

Priority: majorcritical

Important for slow connections, raising.

See also #2815.

Last edited 2 years ago by Antoine Martin (previous) (diff)

comment:3 Changed 21 months ago by Antoine Martin

Milestone: 4.14.2

comment:4 Changed 20 months ago by Antoine Martin

It actually broke through the 1MB barrier today and caused the client connection to drop!

Disconnecting client /run/xpra/localhost.localdomain-2:
 packet size requested is 1719771 but maximum allowed is 1048576

Mostly because of some humongous icons.

comment:5 Changed 17 months ago by migration script

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/2556

Note: See TracTickets for help on using tickets.