Xpra: Ticket #2608: [PATCH] Small FreeBSD tweaks

Here are some patches we have to apply to our x11/xpra port.



Sun, 23 Feb 2020 15:01:54 GMT - arrowd: attachment set


Sun, 23 Feb 2020 15:31:48 GMT - Antoine Martin: owner changed

I've merged the easy part in r25318.

AFAICT, the cups part of this patch is not correct and would change the cups backend path for for non-!FreeBSD to /usr/libexec/cups.


Sun, 23 Feb 2020 15:33:25 GMT - arrowd:

Oh, right, this hunk is plainly wrong. Please, discard it.


Sun, 23 Feb 2020 15:34:54 GMT - arrowd:

Can you please also change

if is_Fedora() or is_CentOS() or is_RedHat():

line to

if is_Fedora() or is_CentOS() or is_RedHat() or FREEBSD:

?


Sun, 23 Feb 2020 15:39:03 GMT - Antoine Martin:

use libexec on FreeBSD : r25319.


Sun, 23 Feb 2020 15:40:43 GMT - Antoine Martin:

Do you still need the change for cups? Something like this perhaps:

@@ -1506,7 +1506,10 @@
             if printing_ENABLED and POSIX:
                 #install "/usr/lib/cups/backend" with 0700 permissions:
-                copytodir("cups/xpraforwarder", "lib/cups/backend", chmod=0o700)
+                lib_cups = "lib/cups"
+                if FREEBSD:
+                    lib_cups = "libexec/cups"
+                copytodir("cups/xpraforwarder", "%s/backend" % lib_cups, chmod=0o700)
             if x11_ENABLED:
                 #install xpra_Xdummy if we need it:

Sun, 23 Feb 2020 15:43:55 GMT - arrowd:

Of course, that'd be great.


Sun, 23 Feb 2020 15:45:28 GMT - Antoine Martin: status changed; resolution set

r25320 for cups path.

That's all of it.


Sun, 23 Feb 2020 17:04:33 GMT - Antoine Martin:

FYI: these patches are now in the v3.0.x branch and will be included in 3.0.7: r25321.


Sat, 23 Jan 2021 05:55:55 GMT - migration script:

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/2608