xpra icon
Bug tracker and wiki

Opened 9 months ago

Closed 9 months ago

#2609 closed defect (fixed)

Some tests are failing on FreeBSD

Reported by: arrowd Owned by: Antoine Martin
Priority: minor Milestone: 4.0
Component: tests Version: trunk
Keywords: Cc:

Description

Here's an output of ./unittests/run3 command on FreeBSD:

2020-02-23 16:34:48,771 Error: read on FastMemoryConnection failed: <class 'TypeError'>
Traceback (most recent call last):
  File "/wrkdirs/usr/ports/x11/xpra/work-py37/xpra-3.0.6/dist/python3/lib/python/xpra/net/protocol.py", line 648, in _io_thread_loop
    while not self._closed and callback():
  File "/wrkdirs/usr/ports/x11/xpra/work-py37/xpra-3.0.6/dist/python3/lib/python/xpra/net/protocol.py", line 730, in _read
    self._process_read(buf)
  File "/wrkdirs/usr/ports/x11/xpra/work-py37/xpra-3.0.6/dist/python3/lib/python/xpra/net/websockets/protocol.py", line 118, in parse_ws_frame
    parsed = decode_hybi(ws_data)
  File "/wrkdirs/usr/ports/x11/xpra/work-py37/xpra-3.0.6/dist/python3/lib/python/xpra/net/websockets/header.py", line 33, in decode_hybi
    b1, b2 = struct.unpack(">BB", buf[:2])
TypeError: a bytes-like object is required, not 'str'
F
======================================================================
FAIL: test_read_speed (__main__.ProtocolTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/wrkdirs/usr/ports/x11/xpra/work-py37/xpra-3.0.6/unittests/unit/net/protocol_test.py", line 137, in test_read_speed
    n, size, elapsed = self.do_test_read_speed(2**i)
  File "/wrkdirs/usr/ports/x11/xpra/work-py37/xpra-3.0.6/unittests/unit/net/protocol_test.py", line 180, in do_test_read_speed
    assert len(parsed_packets)==N*3, "expected to parse %i packets but got %i" % (N*3, len(parsed_packets))
AssertionError: expected to parse 300 packets but got 1

======================================================================
FAIL: test_read_speed (__main__.WebsocketProtocolTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/wrkdirs/usr/ports/x11/xpra/work-py37/xpra-3.0.6/unittests/unit/net/protocol_test.py", line 137, in test_read_speed
    n, size, elapsed = self.do_test_read_speed(2**i)
  File "/wrkdirs/usr/ports/x11/xpra/work-py37/xpra-3.0.6/unittests/unit/net/protocol_test.py", line 180, in do_test_read_speed
    assert len(parsed_packets)==N*3, "expected to parse %i packets but got %i" % (N*3, len(parsed_packets))
AssertionError: expected to parse 300 packets but got 0

----------------------------------------------------------------------
Ran 8 tests in 4.361s

FAILED (failures=2)
failure on unit.net.protocol_test, exit code=1

Are these known ones? If not, any ideas how to fix them?

I'll happily provide more info, or do some debugging, but I need some guidance first.

Change History (1)

comment:1 Changed 9 months ago by Antoine Martin

Resolution: fixed
Status: newclosed

This bug has already been fixed in r25251 (r25252 for the v3 branch - amongst other test fixes) and will be included in the 3.0.7 release.

Note: See TracTickets for help on using tickets.