xpra icon
Bug tracker and wiki

Opened 9 months ago

Closed 6 months ago

#2619 closed defect (fixed)

handle images in win32 clipboard

Reported by: Antoine Martin Owned by: Antoine Martin
Priority: critical Milestone: 4.1
Component: clipboard Version: 3.0.x
Keywords: Cc:

Description (last modified by Antoine Martin)

From ticket:2603#comment:3, the data will look like this:

Error: failed to get clipboard data
 no matching format in DataObject, System.Drawing.Bitmap, CF_BITMAP, Ole Private Data, CF_DIB, CF_DIBV5

And maybe we can re-use the screen capture code to handle BITMAP and / or DIB.

Generic ticket for exotic clipboard formats: #273

Change History (5)

comment:1 Changed 9 months ago by Antoine Martin

Description: modified (diff)
Status: newassigned

comment:2 Changed 7 months ago by Antoine Martin

Priority: majorcritical

comment:3 Changed 6 months ago by Antoine Martin

As of r26546, we can copy from images from the windows clipboard.

TODO:

  • use pillow imagegrab to simplify the code?
  • handle transparency
  • add watermark (generalize the existing code)
  • other direction: copy to the clipboard
Last edited 6 months ago by Antoine Martin (previous) (diff)

comment:4 Changed 6 months ago by Antoine Martin

Updates:

  • r26547 copy images to the clipboard
  • r26549 + r26551: support compressed PNG and JPEG binary formats

TODO: watermark, sanitize binary image data through PIL?

Last edited 6 months ago by Antoine Martin (previous) (diff)

comment:5 Changed 6 months ago by Antoine Martin

Resolution: fixed
Status: assignedclosed
  • r26553 re-uses the same code as X11 for adding watermarks (disabled by default), adding a timestamp (now also disabled) and sanitizing the data (enabled by default)
  • r26554 skips sanitizing when not needed (when we already generated the compressed image data via python-pillow ourselves)
Note: See TracTickets for help on using tickets.