xpra icon
Bug tracker and wiki

Changes between Version 2 and Version 8 of Ticket #2632


Ignore:
Timestamp:
03/11/20 12:45:41 (3 months ago)
Author:
Antoine Martin
Comment:

The fix for #2301 is clearly the cause of this problem.

Left is at keycode 113 on my layout:

keycode 113 = Left NoSymbol Left NoSymbol Left

but there is a NoSymbol for level=1 (when the shift modifier present) so we unpress shift to ensure we end up triggering Left and not NoSymbol. (see #2301 for details)

Updates:

  • r25606: don't change the modifiers list if the key we're pressing is going to be doing that - ie: when handling Shift_L, don't bother adjusting the shift modifier state when locating the keycode (same as what we were already doing in make_keymask_match)
  • r25607: allow NoSymbol to match without adjusting the shift modifier state
  • r25608: also skip adjusting "mode switch" modifier for NoSymbol keys

Backporting all this was not fun: r25609. Fortunately, we already have XPRA_SIMULATE_MODIFIERS=0 so we can easily bypass all of these changes if they cause problems.

@stdedos: updated Xenial 3.0.7-RC server builds are available with this fix.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2632

    • Property Owner changed from Antoine Martin to stdedos
  • Ticket #2632 – Description

    v2 v8  
    1 e.g. Shift+LeftArrow will not select one character. This is a "recent" regression (I don't have a specific point in time; maybe it was working in 3.0.6).
     1e.g. `Shift`+`LeftArrow` will not select one character. This is a "recent" regression (I don't have a specific point in time; maybe it was working in 3.0.6).
    22
    33[[Image(xpra-cannot-shift-arrow-select-GTK_Keyboard_Test_2020-03-10_14-32-07.png)]]