xpra icon
Bug tracker and wiki

Changes between Initial Version and Version 1 of Ticket #2642, comment 3


Ignore:
Timestamp:
03/19/20 15:46:22 (10 months ago)
Author:
Antoine Martin
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #2642, comment 3

    initial v1  
    1 Replying to [comment:2 Antoine Martin]:
    2 > That's very strange, we already had code that prevents using video regions for small areas:
    3 > {{{
    4 >         if cww*cwh<=MAX_NONVIDEO_PIXELS:
    5 >             return nonvideo(quality+30, "window is too small")
    6 > }}}
    7 > And the default value:
    8 > {{{
    9 > MAX_NONVIDEO_PIXELS = envint("XPRA_MAX_NONVIDEO_PIXELS", 1024*4)
    10 > }}}
     1> (..)
    112> So it should not have been possible to use a video encoding for 2x16, unless you somehow forced it with command line options or environment variables?
    123
    134I am trying to keep my changes in the console and in one configuration file, ''and'' as minimal as possible. I am inclining to say no (the changes required here are already complex enough to inadvertently apply them).
    145
    15 > r25632 will ensure we never bother using video for anything smaller than 16 pixels in width or height, since not all CSC modules can handle very small sizes.
    16 > The correct fix would be to add a new capability so the client can tell the server what the minimum size requirements really are, but since all the CSC modules we have support at least 8, I didn't bother.
    17 >
    18 > It would be interesting to see why we ended up choosing video for such add odd looking window region.
    19 >
     6> (..)
    207> Do you know which window triggered it? (r25633 will show the window id in the exception message from now on)
    218